Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): update pipeline to use an Action #82

Merged
merged 2 commits into from
Feb 4, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,17 @@
name: release
name: Publish

on:
push:
tags:
- 'v*.*.*'
jobs:
release:
types: [published, edited]

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: Use Node.js 13.x
uses: actions/setup-node@v1
with:
node-version: 13.x
- uses: actions/cache@v1
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: ${{ runner.os }}-node-
- run: npm ci
- name: update release tags
run: node test/_release.js ${{ secrets.GITHUB_TOKEN }}
- name: Checkout
uses: actions/checkout@v2
with:
ref: ${{ github.event.release.tag_name }}
- uses: JasonEtco/build-and-tag-action@v1
env:
GITHUB_TOKEN: ${{ github.token }}
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@pkgjs/meet",
"version": "0.0.3",
"description": "Make a meeting issue based on a schedule",
"main": "index.js",
"main": "dist/index.js",
"type": "commonjs",
"author": "Wes Todd <[email protected]>",
"license": "MIT",
Expand All @@ -11,6 +11,7 @@
"url": "https://github.com/pkgjs/meet.git"
},
"scripts": {
"build": "npx @vercel/ncc build && npx convert-action",
Copy link
Member

@wesleytodd wesleytodd Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to install convert-action as a dev dep, and then convert the ziet version dev dep to vercel. I know that is not required, but there are good reasons to be explicit about your deps.

"test": "standard && mocha test/index.js",
"test:integration": "standard && mocha",
"preversion": "npm t",
Expand Down
101 changes: 0 additions & 101 deletions test/_release.js

This file was deleted.