ci(release): update pipeline to use an Action #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleytodd
reviewed
Feb 4, 2021
package.json
Outdated
| @@ -11,6 +11,7 @@ | |||
| "url": "https://github.com/pkgjs/meet.git" | |||
| }, | |||
| "scripts": { | |||
| "build": "npx @vercel/ncc build && npx convert-action", | |||
There was a problem hiding this comment.
Would be great to install convert-action as a dev dep, and then convert the ziet version dev dep to vercel. I know that is not required, but there are good reasons to be explicit about your deps.
|
I don't think we need to close that PR since it's unrelated to the files being changed here. |
|
Going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the release pipeline to use @JasonEtco's GitHub Action. I think I've done it right, but eyes would be appreciated. I'm curious if I've missed anything in deleting the release script (looked through it and don't think I have). Also curious if I've implemented the action correctly.