Also supports the name "Python-2.0" #1053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masutaka
added a commit
to liam-hq/liam
that referenced
this pull request
Nov 28, 2024
$ license_finder approvals add 'argparse' \ --version=2.0.1 \ --why 'Python 2.0 license is compatible with Apache-2.0. But License Finder does not support the name "Python-2.0". See pivotal/LicenseFinder#1053' \ --who 'OSPO @masutaka'
This was referenced Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would also like to see support for the name
Python-2.0.This format is used in argparse v2.0.1 (latest).
https://github.com/nodeca/argparse/blob/2.0.1/package.json#L17
I considered submitting a pull request to argparse, but I couldn't figure out why Python-2.0 should be changed to Python 2.0, so I made a pull request to LicenseFinder.