Introduce License Finder to CI #94
Merged
+11,043
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ license_finder permitted_licenses add 'MIT' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/MIT' \ --who 'OSPO @masutaka'
$ license_finder permitted_licenses add 'Apache 2.0' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/apache-2-0' \ --who 'OSPO @masutaka'
$ license_finder permitted_licenses add 'ISC' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/isc-license-txt' \ --who 'OSPO @masutaka'
$ license_finder permitted_licenses add 'BSD 0-Clause' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/0BSD' \ --who 'OSPO @masutaka'
$ license_finder permitted_licenses add 'BSD 2-Clause' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/BSD-2-Clause' \ --who 'OSPO @masutaka'
$ license_finder permitted_licenses add 'BSD 3-Clause' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/BSD-3-Clause' \ --who 'OSPO @masutaka'
$ license_finder permitted_licenses add 'BlueOak-1.0.0' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/blue-oak-model-license' \ --who 'OSPO @masutaka'
$ license_finder permitted_licenses add 'The Unlicense' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/Unlicense' \ --who 'OSPO @masutaka'
$ license_finder permitted_licenses add 'CC-BY-4.0' \ --why 'Compatible with Apache-2.0 license. See https://creativecommons.org/licenses/by/4.0/' \ --who 'OSPO @masutaka'
masutaka
force-pushed
the
introduce-license-finder
branch
from
d1a3f97 to
52fb94a
Compare
$ license_finder approvals add 'argparse' \ --version=2.0.1 \ --why 'Python 2.0 license is compatible with Apache-2.0. But License Finder does not support the name "Python-2.0". See pivotal/LicenseFinder#1053' \ --who 'OSPO @masutaka'
$ license_finder approvals add 'libpg-query' \ --version=13.3.2 \ --why 'Its license is MIT, but it is mis-detected as a "LICENSE IN LICENSE" license. See launchql/libpg-query-node#85' \ --who 'OSPO @masutaka'
masutaka
force-pushed
the
introduce-license-finder
branch
from
f9d4074 to
f30bf82
Compare
masutaka
requested review from
hoshinotsuyoshi,
FunamaYukina,
junkisai,
MH4GF and
sasamuku
and removed request for
a team
MH4GF
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
This is pretty straightforward! 😄
Comment on lines
+67
to
+68
| :why: Public Domain is compatible with Apache-2.0. But it is not a software license. | ||
| See https://github.com/liam-hq/liam/issues/111 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The main branch had more licenses and I will deal with them. 🔗 https://github.com/liam-hq/liam/actions/runs/12081630218/job/33691096256 
|
$ license_finder permitted_licenses add 'LGPL-3.0-or-later' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/LGPL-3.0' \ --who 'OSPO @masutaka'
$ license_finder permitted_licenses add 'CC0 1.0 Universal' \ --why 'Compatible with Apache-2.0 license. See https://creativecommons.org/publicdomain/zero/1.0/' \ --who 'OSPO @masutaka'
$ license_finder approvals add 'spawndamnit' \ --version=3.0.1 \ --why 'Its license is MIT, but it is mis-detected as a "SEE LICENSE IN LICENSE" license. See jamiebuilds/spawndamnit#11' \ --who 'OSPO @masutaka'
$ license_finder permitted_licenses add 'Mozilla Public License 2.0' \ --why 'Compatible with Apache-2.0 license. See https://opensource.org/license/mpl-2-0' \ --who 'OSPO @masutaka'
It's removed by #110
masutaka
force-pushed
the
introduce-license-finder
branch
from
d4f7cfe to
1741ea3
Compare
|
@MH4GF Please review again. The main branch had more licenses, so I added commits 2bd8f75...1741ea3 . 9d698a9 and also created a PR jamiebuilds/spawndamnit#11 in connection with it. |
|
For some reason frontend-ci is down.... |
MH4GF
approved these changes
Nov 29, 2024
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces License Finder to CI for maintaining license compliance.
frontend/config/dependency_decisions.ymlfrontend/docs/packages-license.mdRelated Issues and pull requests
Python-2.0license instead ofargparsepackage #115Changes
Testing
1. Since neither running License Finder nor creating a license report was necessary, they were skippedOther Information
CI_TRIGGER_APP_IDCI_TRIGGER_APP_PRIVATE_KEY