Fleshed out MetricsFrames and their various types to enforce better #468
Conversation
consistency across processors and their different reports.
| @@ -55,7 +56,8 @@ def __post_init__(self): | |||
|
|
|||
| def __str__(self): | |||
| pts = format_pts(self.pts) | |||
| return f"{self.name}(pts: {pts}, size: {len(self.audio)}, frames: {self.num_frames}, sample_rate: {self.sample_rate}, channels: {self.num_channels})" | |||
| return f"{self.name}(pts: {pts}, size: {len(self.audio)}, frames: {self.num_frames}, sample_rate: { | |||
| self.sample_rate}, channels: {self.num_channels})" | |||
There was a problem hiding this comment.
I had the same changes by autopep8. I think they broke something. If we do this change the output will be messed up with carriage return. What I do, before committing, is just revert only these changes. Very annoying, but I haven't found a better way.
There was a problem hiding this comment.
this one actually seems right to me (or almost right. this is wrapping at 108 😕 ). shouldn't it wrap at 100 chars? meanwhile, I agree.. something is up with the formatter because it seems inconsistent
| @@ -0,0 +1,34 @@ | |||
| from typing import Optional | |||
There was a problem hiding this comment.
Since this is a new module, we need an empty __init__.py
src/pipecat/metrics/metrics.py
Outdated
|
|
||
| class TTFBMetricsData(MetricsData): | ||
| value: float | ||
| model: Optional[str] |
There was a problem hiding this comment.
Maybe we can initialize this to None so we don't need to pass it.
model: Optional[str] = None
src/pipecat/metrics/metrics.py
Outdated
|
|
||
| class ProcessingMetricsData(MetricsData): | ||
| value: float | ||
| model: Optional[str] |
src/pipecat/metrics/metrics.py
Outdated
|
|
||
| class TTSUsageMetricsData(MetricsData): | ||
| processor: str | ||
| model: Optional[str] |
There was a problem hiding this comment.
processor: str
value: int
model: Optional[str] = None
| @@ -11,6 +11,7 @@ | |||
| from abc import abstractmethod | |||
| from typing import AsyncGenerator, List, Optional, Tuple | |||
|
|
|||
| from attr import has | |||
There was a problem hiding this comment.
note to self: remove (not sure why this got added)
|
closing in leu of #474 |
consistency across processors and their different reports.