adding "model" to all metrics frames if one exists #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
reviewed
Sep 16, 2024
| @@ -124,13 +134,16 @@ def report_only_initial_ttfb(self): | |||
| def can_generate_metrics(self) -> bool: | |||
| return False | |||
|
|
|||
| def _model_name(self) -> str | None: | |||
| return self._model if hasattr(self, "_model") else None | |||
There was a problem hiding this comment.
I'm not sure this is a good idea. We don't want to force people to remember they have to use _model as a variable name. I believe it might be better to just optionally pass the model to the FrameProcessor functions. Just being more explicit about it.
|
replacing this approach with #468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows us to differentiate across models when handling metrics frames. should also make subclassing easier in general so that the model and processor are always included with various metrics so long as they exist.