Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make crate::parse_result::ParseResult public #43

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Make crate::parse_result::ParseResult public #43

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
057960d
Make crate::parse_result::ParseResult public
levkk Apr 22, 2024
5143c36
bump version
levkk Apr 22, 2024
a9959aa
Move export to lib.rs, remove unused export
levkk Jun 19, 2024
2aaa5fd
remove version bump
levkk Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "pg_query"
description = "PostgreSQL parser that uses the actual PostgreSQL server source to parse SQL queries and return the internal PostgreSQL parse tree."
version = "5.1.0"
version = "5.1.0-1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, what's the motivation here? Is that version format standard in the Rust open source world?

So far we've only bumped the version number when publishing a new release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bump would allow to release this crate without necessarily releasing a new version of pg_query the C library (I believe pg_query.rs was synced with the C library version at some point recently). The versioning is technically semver, but I'm not sure it's strictly how Rust crates do it; typically, only major, minor and patch numbers are used.

edition = "2021"
documentation = "https://docs.rs/pg_query/"
build = "build.rs"
Expand Down
2 changes: 1 addition & 1 deletion src/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use prost::Message;

use crate::bindings::*;
use crate::error::*;
use crate::parse_result::ParseResult;
pub use crate::parse_result::ParseResult;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep all re-exports in the same place, this should probably be moved to lib.rs as pub use parse_result::*, and then this file can replace all imports with a single use crate::*

use crate::protobuf;

/// Represents the resulting fingerprint containing both the raw integer form as well as the
Expand Down
Loading