Make crate::parse_result::ParseResult public
#43
Conversation
src/query.rs
Outdated
| @@ -5,7 +5,7 @@ use prost::Message; | |||
|
|
|||
| use crate::bindings::*; | |||
| use crate::error::*; | |||
| use crate::parse_result::ParseResult; | |||
| pub use crate::parse_result::ParseResult; | |||
There was a problem hiding this comment.
To keep all re-exports in the same place, this should probably be moved to lib.rs as pub use parse_result::*, and then this file can replace all imports with a single use crate::*
Cargo.toml
Outdated
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| name = "pg_query" | |||
| description = "PostgreSQL parser that uses the actual PostgreSQL server source to parse SQL queries and return the internal PostgreSQL parse tree." | |||
| version = "5.1.0" | |||
| version = "5.1.0-1" | |||
There was a problem hiding this comment.
I'm curious, what's the motivation here? Is that version format standard in the Rust open source world?
So far we've only bumped the version number when publishing a new release.
There was a problem hiding this comment.
The version bump would allow to release this crate without necessarily releasing a new version of pg_query the C library (I believe pg_query.rs was synced with the C library version at some point recently). The versioning is technically semver, but I'm not sure it's strictly how Rust crates do it; typically, only major, minor and patch numbers are used.
parse_result::ParseResultis returned fromcrate::query::parsewhich is a public method but the result struct is private. This compiles and runs fine typically, but it's impossible to pass the output ofparseto other functions since we can't import the private struct and declare it as an input variable.