Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] [Chore] Add error for unwanted console.logs in the UI #830

Merged
merged 13 commits into from
Nov 19, 2024
Merged
1 change: 1 addition & 0 deletions ui/apps/everest/move-build.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const checkDistEnvVarAndMove = async () => {
? envDir
: path.join(process.cwd(), '../..', envDir);

// eslint-disable-next-line no-console
console.log(`Outputting Everest files to: ${outDir}`);

fs.rmSync(outDir, { force: true, recursive: true });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,5 @@ export const Messages = {
description: `Define the structure, set access controls, and start organizing
your information efficiently.`,
},
card2: {
header: 'Set default configurations',
description: `Customize settings and ensure that your database operates
optimally from the get-go.`,
},
letsGo: "Let's go",
};
Original file line number Diff line number Diff line change
Expand Up @@ -38,34 +38,6 @@ export const WelcomeDialog = ({
{Messages.start}
</Typography>
</Stack>
{/* TODO: uncomment when default settings page is ready */}
{/* <Divider />
<Typography variant="subHead1" sx={{ p: '24px 44px 8px 44px' }}>
{Messages.subHead2}
</Typography>
<Box
sx={{
display: 'flex',
gap: '12px',
justifyContent: 'center',
px: '44px',
}}
>
<CardLink
Icon={AddCircleOutlineIcon}
action={Messages.card1.header}
description={Messages.card1.description}
link="/databases/new"
handleCloseModal={closeDialog}
/>
<CardLink
Icon={SettingsOutlinedIcon}
action={Messages.card2.header}
description={Messages.card2.description}
link="/settings"
handleCloseModal={closeDialog}
/>
</Box> */}
</DialogContent>
{/* TODO: remove dialog actions when cards are uncommented */}
<DialogActions sx={{ mt: 4 }}>
Expand Down
1 change: 1 addition & 0 deletions ui/apps/everest/src/main.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
import ReactDOM from 'react-dom/client';
import App from 'App';

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion ui/apps/everest/src/pages/settings/settings.messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.
export const Messages = {
defaultConfigurations: 'Default configurations',
storageLocations: 'Backups storages',
monitoringEndpoints: 'Monitoring endpoints',
namespaces: 'Namespaces',
Expand Down
2 changes: 0 additions & 2 deletions ui/apps/everest/src/pages/settings/settings.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,13 @@
// See the License for the specific language governing permissions and
// limitations under the License.
export enum SettingsTabs {
// defaultConfigurations = 'default-configurations',
storageLocations = 'storage-locations',
monitoringEndpoints = 'monitoring-endpoints',
namespaces = 'namespaces',
// k8sClusters = 'k8s-clusters',
}

export const settingsTabsMui: Record<SettingsTabs, number> = {
// [SettingsTabs.defaultConfigurations]: 0,
[SettingsTabs.storageLocations]: 1,
[SettingsTabs.monitoringEndpoints]: 2,
[SettingsTabs.namespaces]: 3,
Expand Down
4 changes: 0 additions & 4 deletions ui/apps/everest/src/router.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,6 @@ const router = createBrowserRouter([
path: 'settings',
element: <Settings />,
children: [
// {
// path: SettingsTabs.defaultConfigurations,
// element: <DefaultConfigurations />,
// },
{
path: SettingsTabs.storageLocations,
element: <StorageLocations />,
Expand Down
Loading
Loading