-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] [Chore] Add error for unwanted console.logs in the UI #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oksana-grishchenko
approved these changes
Nov 13, 2024
fabio-silva
requested changes
Nov 13, 2024
ui/apps/everest/src/pages/settings/default-configurations/default-configurations.tsx
Outdated
Show resolved
Hide resolved
fabio-silva
approved these changes
Nov 19, 2024
mayankshah1607
pushed a commit
that referenced
this pull request
Nov 19, 2024
* chore: add rule for logs * test * test * add rule, add exceptions * disable for main.tsx * revert changes to FE CI Gatekeeper * remove unnecessary commit and onSubmit * refactor: remove default configuration component * fix: container too small for multi row noData alerts for Table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console.log
inui/apps/everest/src/components/nav-item/NavItem.tsx
for visibility (will remove before merging)