Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] [Chore] Add error for unwanted console.logs in the UI #830

Merged
merged 13 commits into from
Nov 19, 2024

Conversation

dianabirs
Copy link
Contributor

@dianabirs dianabirs commented Nov 13, 2024

  • added rule to mark console logs as errors by linter
  • added exceptions in the files that have necessary log statements
  • left a console.log in ui/apps/everest/src/components/nav-item/NavItem.tsx for visibility (will remove before merging)

@dianabirs dianabirs marked this pull request as ready for review November 13, 2024 10:07
@dianabirs dianabirs requested review from a team as code owners November 13, 2024 10:07
@fabio-silva fabio-silva self-requested a review November 19, 2024 09:53
@dianabirs dianabirs merged commit 1d44ec7 into main Nov 19, 2024
8 checks passed
@dianabirs dianabirs deleted the chore/add-eslint-warning-for-logs branch November 19, 2024 09:58
mayankshah1607 pushed a commit that referenced this pull request Nov 19, 2024
* chore: add rule for logs

* test

* test

* add rule, add exceptions

* disable for main.tsx

* revert changes to FE CI Gatekeeper

* remove unnecessary commit and onSubmit

* refactor: remove default configuration component

* fix: container too small for multi row noData alerts for Table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants