Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect existing GC::Profiler.enabled? state #4

Closed
wants to merge 1 commit into from
Closed

Respect existing GC::Profiler.enabled? state #4

wants to merge 1 commit into from

Commits on Jun 17, 2014

  1. Respect existing GC::Profiler.enabled? state 

    Currently peek-gc will enable and disable GC::Profiler before every
request. This has unfortunate side-effects if anyone else has set
`GC::Profiler.enable` and assumes the setting won't be changed under
them.

newrelic_rpm was making this assumption (which we're fixing
in the upcoming release), but I thought others might benefit from being a
little more cautious here.

Note that there's still an issue here related to different conflicting
code calling `GC::Profiler.clear`, but I don't have a good solution to
that. At the very least preserving the existing setting on this seemed
less likely to cause suprises.
    @jasonrclark
    jasonrclark committed Jun 17, 2014
    Configuration menu
    Copy the full SHA
    db73adf View commit details
    Browse the repository at this point in the history