Respect existing GC::Profiler.enabled? state #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently peek-gc will enable and disable GC::Profiler before every request. This has unfortunate side-effects if anyone else has set `GC::Profiler.enable` and assumes the setting won't be changed under them. newrelic_rpm was making this assumption (which we're fixing in the upcoming release), but I thought others might benefit from being a little more cautious here. Note that there's still an issue here related to different conflicting code calling `GC::Profiler.clear`, but I don't have a good solution to that. At the very least preserving the existing setting on this seemed less likely to cause suprises.
|
D'oh, should have looked at the repo. Looks like this dups #3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently peek-gc will enable and disable GC::Profiler before every request.
This has unfortunate side-effects if anyone else has set
GC::Profiler.enableand assumes the setting won't be changed under them.newrelic_rpm was making this assumption (which we're fixing in the upcoming
release), but I thought others might benefit from being a little more cautious
here.
Note that there's still an issue here related to different conflicting code
calling
GC::Profiler.clear, but I don't have a good solution to that. At thevery least preserving the existing setting on this seemed less likely to cause
suprises.