Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

Default SortOrder to values for ContentContactSortInput #995

Closed
wants to merge 1 commit into from
Closed

Default SortOrder to values for ContentContactSortInput #995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion services/graphql-server/src/graphql/definitions/platform/content/types/contact.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ input ContentContactOwnedContentInput {

input ContentContactSortInput {
field: ContentContactSortField = id
order: SortOrder = desc
order: SortOrder = values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the order input value from the website be changed? Changing the default here will change it for everyone, not just the requesting customer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could, that was part of my suggestion in the main PR comment: "Alternatively adjust here: https://github.com/parameter1/base-cms/blob/master/packages/marko-web-theme-monorail/graphql/fragments/content-page.js#L129 or utilize a tenant/site level defined fragment that changes the sort order as well."

Likely depends on to what scope is this considered "broken" or if we want to change it for everyone etc. @brandonbk thoughts?

}

input CreateContentContactMutationInput {
Expand Down
Loading