Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

Default SortOrder to values for ContentContactSortInput #995

Closed
wants to merge 1 commit into from

Conversation

Shinsina
Copy link
Member

Alternatively adjust here: https://github.com/parameter1/base-cms/blob/master/packages/marko-web-theme-monorail/graphql/fragments/content-page.js#L129 or utilize a tenant/site level defined fragment that changes the sort order as well.

No Change:
Screenshot from 2024-10-23 09-01-11

Following Change:
Screenshot from 2024-10-23 09-00-55

@Shinsina
Copy link
Member Author

Author Order

@@ -63,7 +63,7 @@ input ContentContactOwnedContentInput {

input ContentContactSortInput {
field: ContentContactSortField = id
order: SortOrder = desc
order: SortOrder = values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the order input value from the website be changed? Changing the default here will change it for everyone, not just the requesting customer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could, that was part of my suggestion in the main PR comment: "Alternatively adjust here: https://github.com/parameter1/base-cms/blob/master/packages/marko-web-theme-monorail/graphql/fragments/content-page.js#L129 or utilize a tenant/site level defined fragment that changes the sort order as well."

Likely depends on to what scope is this considered "broken" or if we want to change it for everyone etc. @brandonbk thoughts?

@Shinsina Shinsina marked this pull request as draft October 30, 2024 13:07
@Shinsina
Copy link
Member Author

Shinsina commented Nov 6, 2024

Closing in favor of a site/tenant specific correction here: https://github.com/parameter1/transpire-media-websites/pull/93

@Shinsina Shinsina closed this Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants