Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] run tests with all python >=3.9 #6

Merged
merged 2 commits into from
Oct 4, 2024
Merged

[MAINT] run tests with all python >=3.9 #6

merged 2 commits into from
Oct 4, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Oct 3, 2024

  • drop python<3.8
  • support all python >= 3.9: test in CI

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Oct 3, 2024

will rebase on main once #5 is merged

@tsalo
Copy link
Contributor

tsalo commented Oct 3, 2024

lol you figured out the problem so much faster than me. I think the type annotations with | require at least Python 3.10 though.

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Oct 3, 2024

na adding from __future__ import annotations at the top of the module should be fine

@tsalo
Copy link
Contributor

tsalo commented Oct 3, 2024

Oh cool! I'll put that in my PR then.

@Remi-Gau Remi-Gau marked this pull request as ready for review October 3, 2024 14:31
@Remi-Gau Remi-Gau mentioned this pull request Oct 3, 2024
Merged
@Remi-Gau Remi-Gau mentioned this pull request Oct 3, 2024
Merged
@paquiteau paquiteau merged commit de008b5 into paquiteau:master Oct 4, 2024
5 checks passed
@Remi-Gau Remi-Gau deleted the py3.9 branch October 7, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paquiteau paquiteau paquiteau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Remi-Gau @tsalo @paquiteau