-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address linting and test errors #5
Conversation
Hi, no worries, Any help is welcome! |
It looks like the linter-check job runs black, but style issues flagged by that step don't affect the job's status? I.e., it's passing now, but if I navigate to the Black Check step in the CI log there are a bunch of things black would change. |
@tsalo: aren't you afraid that adding the word typo in the title of the PR may summon the codespell demon? (AKA @yarikoptic) 😜 |
oohhh good point! 😄 Plus this is mostly about getting the linter and tests passing at this point anyway |
yay: all green ! |
Thank you for the clean up! I guess we have a good starting point to built upon :) |
Weird... CI is failing on Also the docs build needs to be fixed. |
is that a flaky test ? |
I can reliably get it locally. |
OK my bad: when running locally in proper virtual environment (and not my usual conda 'ecosystem' - larger and meaner than an environment), everything is OK. So I would try merging #6 to stop supporting py3.8 and get rid of the error. |
Sounds good to me! |
|
Apologies for the unsolicited PR. I mostly just wanted to see why tests were failing in the last commit, but the logs were expired.