-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespell support (config, workflow to detect/not fix) and make it fix few typos #12
Conversation
…(but ignoring overall fail due to ambigous ones) === Do not change lines below === { "chain": [], "cmd": "codespell -w || :", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
=== Do not change lines below === { "chain": [], "cmd": "codespell -w -i 3 -C 2", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
Hi thanks for the PR Any reason to not put it inside the linter workflow (with black and ruff) ? Otherwise LGTM :) |
That's because the spell of @yarikoptic sets things in separate workflow by default. If I am not mistaken this whole PR was created by casting the spell with a single command on his terminal. |
I can take care to integrate into the linting workflow in a follow up PR. |
Correct. It is this little helper: happen you would like to cast spells too ;) but if you are really into casting, check those out https://github.com/datalad/screencaster which could make you appear really like a magician while giving life demos -- "typing" commands very fast and without mistakes, while still potentially interactively working in that terminal. @adswa can attest that it brings awe to the audience ;) |
if this conversation continues I am going to create a bunch of alias that are harry potter based: I'll start
|
Awesome stuff @yarikoptic you truly are a wizard with more mana than me 😅 Let's get done with this though 😊 |
Blame @Remi-Gau
More about codespell: https://github.com/codespell-project/codespell .
I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback.
CI workflow has 'permissions' set only to 'read' so also should be safe.