Map Note View UI Changes & Published Notes Redirect #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 19, 2024 11:47
…om the media field
yashb196
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to bring changes to the Map Note View, NoteDetailModal, and to change the navigation of the published notes to this view, instead of the current view which is an edit note screen without the ability to edit the note. As of now the Map Note View looks like this:
The images and the text for the note are shown separately, which completely disregards the story that the Ethnographer is trying to tell. Thus, this change puts the images away and puts it into the text inline in the same way that the user inputs it into the Note themselves. The image scroller is still a valuable tool, so now a button is present in the top right corner which allows the user to view the pictures like before.
With this pull request, this page will be changed to have buttons for both the video and the image at the top right of the modal. These buttons can be pressed so that the images and videos can be viewed separately. It should be noted that images will still be displayed on the note, although, it is not optimized yet! Below is the updated version of the NoteDetailModal, as well as, the views for both ImageModal and VideoModal. There are also test cases for this pull request.
Updated NoteDetailModal:
ImageModal:
VideoModal:
