Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enhancement proposal for SDN live migration #1064

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Add enhancement proposal for SDN live migration #1064

merged 1 commit into from
Oct 26, 2023

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Mar 18, 2022

Signed-off-by: Peng Liu [email protected]

@openshift-ci openshift-ci bot requested review from danwinship and dcbw March 18, 2022 02:44
@pliurh
Copy link
Contributor Author

pliurh commented Mar 18, 2022

/cc @trozet @cgwalters @squeed PTAL.

jewzaam
jewzaam reviewed Mar 18, 2022
View reviewed changes
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Show resolved Hide resolved
danwinship
danwinship reviewed Mar 21, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
cgwalters
cgwalters reviewed Mar 21, 2022
View reviewed changes
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
@pliurh
Copy link
Contributor Author

pliurh commented Mar 29, 2022

/cc @russellb

@openshift-ci openshift-ci bot requested a review from russellb March 29, 2022 08:50
@pliurh pliurh force-pushed the live-migration branch 3 times, most recently from 223d158 to fadbcfe Compare April 21, 2022 11:19
@pliurh pliurh force-pushed the live-migration branch 3 times, most recently from fb265d5 to 650b339 Compare June 28, 2022 07:40
@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2022
@pliurh
Copy link
Contributor Author

pliurh commented Aug 1, 2022

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 1, 2022
@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2022
@pliurh
Copy link
Contributor Author

pliurh commented Aug 30, 2022

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2022
jcaamano
jcaamano reviewed Oct 18, 2023
View reviewed changes
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
enhancements/network/sdn-live-migration.md Outdated Show resolved Hide resolved
@pliurh pliurh force-pushed the live-migration branch 2 times, most recently from 5ccc533 to 6627327 Compare October 23, 2023 07:03
cblecker
cblecker approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of SD Architecture as of 318dfb5

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcaamano
Copy link
Contributor

/lgtm

@jcaamano
Copy link
Contributor

jcaamano commented Oct 24, 2023 •
edited
Loading

/hold

@pliurh in case you need more feedback. Feel free to unhold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
kyrtapz
kyrtapz reviewed Oct 25, 2023
View reviewed changes
enhancements/network/sdn-live-migration.md Outdated
1400 for OVN Kubernetes and 1450 for OpenShift SDN. During the migration, this
MTU mismatch would break some cross-CNI traffic.

To avoid this issue, before starting the migration, users need to decrease the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is MTU migration automated or not?
This sentence suggests that it is not but there is also this one:

CNO will check the current hardware MTU and the cluster MTU to see if there is enough free space for OVN-K overlay overhead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MTU migration will be part of the live migration, so it will be automated. Let me make the sentences more clear.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a clarification: it is only automated in the scope of this procedure because it doesn't contemplate the need to update the physical network MTU. This probably worth adding as well.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@kyrtapz
Copy link
Contributor

kyrtapz commented Oct 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@pliurh
Copy link
Contributor Author

pliurh commented Oct 26, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2023

@pliurh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 43ae3ee into openshift:master Oct 26, 2023
@kyrtapz kyrtapz mentioned this pull request Oct 27, 2023
Merged
@pliurh pliurh mentioned this pull request Nov 22, 2023
Merged
martinkennelly added a commit to martinkennelly/release that referenced this pull request Jan 19, 2024
@martinkennelly
CNI live migration: add jobs to CNO and OVN-K
9bdea0e 
For details of the CNI migration feature
see the feature enhancement PR [1].

Within o/origin, there is a suite for live migration.
The suite accepts one environment variable.
The value of this environment variable controls
which CNI we are migrating to and optionally, if we
want to trigger rollback. Rollback will only start
once live migration to the target CNI is complete.
If the environemnt variables value is blank, live
migration test will be skipped. For more info,
see the o/origin live migration PR [2].

Note: enabling of eip feature tests depends on fixing
a bug [3]. A bug to track this enabling has also been
created [4].

[1] openshift/enhancements#1064
[2] openshift/origin#28462
[3] https://issues.redhat.com/browse/OCPBUGS-26196
[4] https://issues.redhat.com/browse/NP-884

Signed-off-by: Martin Kennelly <[email protected]>
openshift-merge-bot bot pushed a commit to openshift/release that referenced this pull request Jan 23, 2024
@martinkennelly
CNI live migration: add jobs to CNO and OVN-K (#46805)
dad2508 
For details of the CNI migration feature
see the feature enhancement PR [1].

Within o/origin, there is a suite for live migration.
The suite accepts one environment variable.
The value of this environment variable controls
which CNI we are migrating to and optionally, if we
want to trigger rollback. Rollback will only start
once live migration to the target CNI is complete.
If the environemnt variables value is blank, live
migration test will be skipped. For more info,
see the o/origin live migration PR [2].

Note: enabling of eip feature tests depends on fixing
a bug [3]. A bug to track this enabling has also been
created [4].

[1] openshift/enhancements#1064
[2] openshift/origin#28462
[3] https://issues.redhat.com/browse/OCPBUGS-26196
[4] https://issues.redhat.com/browse/NP-884

Signed-off-by: Martin Kennelly <[email protected]>
skordas pushed a commit to skordas/release that referenced this pull request Jan 23, 2024
@martinkennelly @skordas
CNI live migration: add jobs to CNO and OVN-K (openshift#46805)
32f8296 
For details of the CNI migration feature
see the feature enhancement PR [1].

Within o/origin, there is a suite for live migration.
The suite accepts one environment variable.
The value of this environment variable controls
which CNI we are migrating to and optionally, if we
want to trigger rollback. Rollback will only start
once live migration to the target CNI is complete.
If the environemnt variables value is blank, live
migration test will be skipped. For more info,
see the o/origin live migration PR [2].

Note: enabling of eip feature tests depends on fixing
a bug [3]. A bug to track this enabling has also been
created [4].

[1] openshift/enhancements#1064
[2] openshift/origin#28462
[3] https://issues.redhat.com/browse/OCPBUGS-26196
[4] https://issues.redhat.com/browse/NP-884

Signed-off-by: Martin Kennelly <[email protected]>
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
@martinkennelly @memodi
CNI live migration: add jobs to CNO and OVN-K (openshift#46805)
df61e93 
For details of the CNI migration feature
see the feature enhancement PR [1].

Within o/origin, there is a suite for live migration.
The suite accepts one environment variable.
The value of this environment variable controls
which CNI we are migrating to and optionally, if we
want to trigger rollback. Rollback will only start
once live migration to the target CNI is complete.
If the environemnt variables value is blank, live
migration test will be skipped. For more info,
see the o/origin live migration PR [2].

Note: enabling of eip feature tests depends on fixing
a bug [3]. A bug to track this enabling has also been
created [4].

[1] openshift/enhancements#1064
[2] openshift/origin#28462
[3] https://issues.redhat.com/browse/OCPBUGS-26196
[4] https://issues.redhat.com/browse/NP-884

Signed-off-by: Martin Kennelly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrtapz kyrtapz kyrtapz left review comments

@jcaamano jcaamano jcaamano left review comments

@martinkennelly martinkennelly martinkennelly left review comments

@dcbw dcbw dcbw left review comments

@trozet trozet trozet left review comments

@Makdaam Makdaam Makdaam left review comments

@jewzaam jewzaam jewzaam left review comments

@russellb russellb russellb left review comments

@cgwalters cgwalters cgwalters left review comments

@mwoodson mwoodson mwoodson left review comments

@danwinship danwinship danwinship left review comments

@cblecker cblecker cblecker approved these changes

Assignees

@jcaamano jcaamano

@kyrtapz kyrtapz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.