Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NP-615: Live migration #2091

Merged
merged 2 commits into from
Dec 7, 2023
Merged

NP-615: Live migration #2091

merged 2 commits into from
Dec 7, 2023

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Nov 2, 2023 •
edited
Loading

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2023
@pliurh pliurh marked this pull request as draft November 2, 2023 09:43
@openshift-ci openshift-ci bot requested review from danwinship and tssurya November 2, 2023 09:45
@pliurh pliurh force-pushed the live_migration branch 2 times, most recently from a5ca6a3 to cea7807 Compare November 8, 2023 07:28
@pliurh pliurh marked this pull request as ready for review November 22, 2023 14:27
@pliurh
Copy link
Contributor Author

pliurh commented Nov 22, 2023

This PR is blocked openshift/api#1640. Besides the API update, it is ready for review.
/cc @kyrtapz @martinkennelly

@pliurh pliurh changed the title WIP: Live migration Live migration Nov 22, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2023
@pliurh
Copy link
Contributor Author

pliurh commented Nov 22, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2023
@pliurh pliurh force-pushed the live_migration branch 8 times, most recently from 3728e82 to 6569070 Compare November 28, 2023 08:30
kyrtapz
kyrtapz reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@kyrtapz kyrtapz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the manifests.
I will go through the code changes next.

bindata/network/multus/multus.yaml Show resolved Hide resolved
bindata/network/multus/multus.yaml Outdated Show resolved Hide resolved
bindata/network/multus/multus.yaml Show resolved Hide resolved
bindata/network/multus/multus.yaml Outdated Show resolved Hide resolved
bindata/network/multus/multus.yaml Outdated Show resolved Hide resolved
bindata/network/ovn-kubernetes/self-hosted/multi-zone-interconnect/ovnkube-node.yaml Outdated Show resolved Hide resolved
bindata/network/ovn-kubernetes/self-hosted/multi-zone-interconnect/ovnkube-node.yaml Outdated Show resolved Hide resolved
bindata/network/ovn-kubernetes/self-hosted/multi-zone-interconnect/ovnkube-node.yaml Outdated Show resolved Hide resolved
bindata/network/ovn-kubernetes/self-hosted/multi-zone-interconnect/ovnkube-node.yaml Outdated Show resolved Hide resolved
bindata/network/multus/multus.yaml Show resolved Hide resolved
kyrtapz
kyrtapz reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@kyrtapz kyrtapz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the code but will need a second pass.

pkg/controller/clusterconfig/clusterconfig_controller.go Outdated Show resolved Hide resolved
manifests/0000_70_cluster-network-operator_01_crd.yaml Outdated Show resolved Hide resolved
pkg/controller/clusterconfig/migration.go Show resolved Hide resolved
pkg/controller/clusterconfig/migration.go Outdated Show resolved Hide resolved
pkg/controller/clusterconfig/migration.go Outdated Show resolved Hide resolved
pkg/controller/operconfig/operconfig_controller.go Outdated Show resolved Hide resolved
pkg/names/names.go Outdated Show resolved Hide resolved
pkg/controller/operconfig/operconfig_controller.go Outdated Show resolved Hide resolved
pkg/network/multus.go Outdated Show resolved Hide resolved
pkg/network/render.go Outdated Show resolved Hide resolved
@pliurh pliurh force-pushed the live_migration branch 3 times, most recently from 650714a to 09f08d8 Compare November 29, 2023 08:06
@pliurh
Copy link
Contributor Author

pliurh commented Dec 5, 2023

/retest

@kyrtapz
Copy link
Contributor

kyrtapz commented Dec 5, 2023

/retest

@kyrtapz
Copy link
Contributor

kyrtapz commented Dec 5, 2023 •
edited
Loading

hypershift failure looks unrelated, it happens across all PRs:

Failed to generate payload: error getting ignition payload: failed to execute cluster-config-operator: cluster-config-operator process failed: /payloads/get-payload203317845/bin/cluster-config-operator: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by /payloads/get-payload203317845/bin/cluster-config-operator)
      /payloads/get-payload203317845/bin/cluster-config-operator: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by /payloads/get-payload203317845/bin/cluster-config-operator

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-network-operator/2091/pull-ci-openshift-cluster-network-operator-master-e2e-hypershift-ovn/1731985523595022336/artifacts/e2e-hypershift-ovn/run-e2e/artifacts/TestCreateCluster/namespaces/e2e-clusters-cvf29/hypershift.openshift.io/nodepools/example-45s4g-us-east-1a.yaml

thread: https://redhat-internal.slack.com/archives/C01C8502FMM/p1701716323597559

@pliurh
Copy link
Contributor Author

pliurh commented Dec 6, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2023
@pliurh
Copy link
Contributor Author

pliurh commented Dec 6, 2023

/retest

kyrtapz
kyrtapz approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@kyrtapz kyrtapz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've successfully tested the migration from SDN to OVNKubernetes and back.
Great job @pliurh!

pkg/network/node_identity.go Outdated Show resolved Hide resolved
pkg/network/multus.go Outdated Show resolved Hide resolved
@kyrtapz
Copy link
Contributor

kyrtapz commented Dec 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
trozet
trozet approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 353b474 and 2 for PR HEAD 16d6457 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2023
@kyrtapz
Copy link
Contributor

kyrtapz commented Dec 7, 2023

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

@pliurh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-dualstack da0e780 link false /test e2e-azure-ovn-dualstack
ci/prow/e2e-vsphere-ovn da0e780 link false /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 da0e780 link false /test e2e-vsphere-ovn-dualstack-primaryv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyrtapz
Copy link
Contributor

kyrtapz commented Dec 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, pliurh, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f383fca into openshift:master Dec 7, 2023
37 of 40 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.16.0-202312071632.p0.gf383fca.assembly.stream for distgit cluster-network-operator.
All builds following this will include this PR.

@martinkennelly
Copy link
Contributor

Belated /lgtm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrtapz kyrtapz kyrtapz approved these changes

@trozet trozet trozet approved these changes

@danwinship danwinship Awaiting requested review from danwinship

@tssurya tssurya Awaiting requested review from tssurya

@martinkennelly martinkennelly Awaiting requested review from martinkennelly

@abhat abhat Awaiting requested review from abhat

Assignees

@kyrtapz kyrtapz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pliurh @zshi-redhat @kyrtapz @openshift-ci-robot @openshift-bot @martinkennelly @trozet @openshift-merge-robot