Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/gcp: check error when building client #724

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

pkg/gcp: check error when building client #724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa618ab
pkg/gcp: check error when building client
patrickdillon Jul 15, 2024
edafa8e
pin oauth2 due to default universe_domain
patrickdillon Jul 16, 2024
e0971da
vendor
patrickdillon Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,3 +168,7 @@ require (
sigs.k8s.io/kube-storage-version-migrator v0.0.4 // indirect
sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
)

replace golang.org/x/oauth2 => golang.org/x/oauth2 v0.15.0

replace google.golang.org/api => google.golang.org/api v0.157.0
1,730 changes: 1,638 additions & 92 deletions go.sum
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions pkg/gcp/actuator/actuator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,9 @@ func (a *Actuator) buildReadGCPClient(cr *minterv1.CredentialsRequest) (ccgcp.Cl

logger.Debug("creating read GCP client")
client, err := a.GCPClientBuilder(a.ProjectName, jsonBytes)
if err != nil {
return nil, fmt.Errorf("failed to build GCP client: %w", err)
}

// Test if the read-only client is working, if any error here we will fall back to using
// the root client.
Expand Down
78 changes: 5 additions & 73 deletions vendor/golang.org/x/oauth2/google/default.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

86 changes: 84 additions & 2 deletions vendor/golang.org/x/oauth2/google/doc.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading