Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLAT-1781: api bump for host zonal infra change #294

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2024

@jcpowermac: This pull request references SPLAT-1781 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2024
@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed August 28, 2024 13:15
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2024
@jcpowermac jcpowermac force-pushed the host-zonal-bump branch 2 times, most recently from 2b8c555 to 683798b Compare September 16, 2024 18:07
@jcpowermac jcpowermac force-pushed the host-zonal-bump branch 4 times, most recently from 16f9a96 to 3be5d60 Compare October 2, 2024 13:17
@jcpowermac jcpowermac force-pushed the host-zonal-bump branch 4 times, most recently from 73020f5 to a03b576 Compare October 30, 2024 12:44
@Phaow
Copy link

Phaow commented Nov 11, 2024

Hi @jcpowermac, I'm doing storage CSI pre merge testing with respect to host group configuration. It seems the PR need rebase somehow not sure why the tide bot does not recongize this while the clusterbot pre build failed of ->

build 4.18,openshift/client-go#294,openshift/machine-api-operator#1285,openshift/cluster-control-plane-machine-set-operator#325,openshift/api#1999,openshift/library-go#1782,openshift/installer#8873

Cluster Bot
APP  08:54
pull request openshift/client-go#294 needs to be rebased to branch master

Could you help rebase the codes when you get a chance? Thanks!

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 2, 2024

@jcpowermac: This pull request references SPLAT-1781 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Changes

  • API bump for vm host zone infrastructure changes

Additional PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac jcpowermac changed the title WIP - SPLAT-1781: api bump for host zonal infra change SPLAT-1781: api bump for host zonal infra change Dec 2, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2024
Copy link
Contributor

openshift-ci bot commented Dec 2, 2024

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@jcpowermac
Copy link
Contributor Author

/assign @JoelSpeed

@JoelSpeed
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, JoelSpeed, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 452dfb8 into openshift:master Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants