Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLAT-1976: Add vSphere VM Host Zonal updates to testutils #373

Merged

Conversation

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2025
@jcpowermac jcpowermac changed the title [wip] Add vSphere VM Host Zonal updates to testutils [wip] SPLAT-1976: Add vSphere VM Host Zonal updates to testutils Jan 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2025

@jcpowermac jcpowermac force-pushed the vsphere-vm-host-zonal branch from 3d010de to 73436ae Compare January 8, 2025 20:18
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2025

@jcpowermac: This pull request references SPLAT-1976 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Changes

  • Add InfrastructureBuilder WithVSphereVMHostZonal()
  • Modify VSphereProviderSpecBuilder Build() to include VMGroup.
  • Fix linting issues
  • Bump API to current

Additional PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Add InfrastructureBuilder WithVSphereVMHostZonal()
Modify VSphereProviderSpecBuilder Build() to include VMGroup.
Fix linting issues
Bump API to current
@jcpowermac jcpowermac force-pushed the vsphere-vm-host-zonal branch from 73436ae to 3024460 Compare January 8, 2025 20:22
@jcpowermac jcpowermac changed the title [wip] SPLAT-1976: Add vSphere VM Host Zonal updates to testutils SPLAT-1976: Add vSphere VM Host Zonal updates to testutils Jan 8, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2025
@vr4manta
Copy link
Contributor

vr4manta commented Jan 8, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@jcpowermac
Copy link
Contributor Author

/assign @JoelSpeed
These changes are to start addressing @elmiko review: openshift/cluster-control-plane-machine-set-operator#325 (comment)

@JoelSpeed
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d674806 into openshift:master Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants