[release-v1.15] fix: add case for DNS resolve fail in TestDialUnreachable #1017
Conversation
Signed-off-by: David Fridrich <[email protected]>
|
/cherry-pick release-v1.16 |
|
@creydr: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-v1.15 #1017 +/- ##
================================================
Coverage ? 64.99%
================================================
Files ? 129
Lines ? 15408
Branches ? 0
================================================
Hits ? 10014
Misses ? 4423
Partials ? 971
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/override "serverless-operator-135-ec / kn-plugin-func-func-util-115" |
|
@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Red Hat Konflux / serverless-operator-135-ec / kn-plugin-func-func-util-115" |
|
@matejvasek: Overrode contexts on behalf of matejvasek: Red Hat Konflux / serverless-operator-135-ec / kn-plugin-func-func-util-115 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "ci/prow/417-e2e-oncluster-test ci/prow/417-images ci/prow/417-unit" |
|
@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/417-e2e-oncluster-test |
|
@matejvasek: Overrode contexts on behalf of matejvasek: ci/prow/417-e2e-oncluster-test, ci/prow/417-images, ci/prow/417-unit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 1d33923
into
openshift-knative:release-v1.15
|
@creydr: new pull request created: #1018 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Backport of https://github.com/knative/func/pull/2619/files