Skip to content

Commit

Permalink
add case for DNS resolve fail (knative#2619) (#1017)
Browse files Browse the repository at this point in the history
Signed-off-by: David Fridrich <[email protected]>
Co-authored-by: David Fridrich <[email protected]>
  • Loading branch information
creydr and gauron99 authored Dec 17, 2024
1 parent 76eb156 commit 1d33923
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/k8s/dialer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func TestDialUnreachable(t *testing.T) {
t.Error("error was expected but got nil")
return
}
if !strings.Contains(err.Error(), "no such host") {
if !strings.Contains(err.Error(), "no such host") && !strings.Contains(err.Error(), "does not resolve") {
t.Errorf("error %q doesn't contain expected substring: ", err.Error())
}

Expand Down

1 comment on commit 1d33923

@creydr
Copy link
Member Author

@creydr creydr commented on 1d33923 Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest kn-plugin-func-func-util-115-on-push branch:release-v1.15

Please sign in to comment.