Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS and ROR #1353

Closed
danielskatz opened this issue Aug 2, 2024 · 15 comments · Fixed by #1362
Closed

JOSS and ROR #1353

danielskatz opened this issue Aug 2, 2024 · 15 comments · Fixed by #1362

Comments

@danielskatz
Copy link
Collaborator

If JOSS asked authors to use RORs to indicate their affiliations, we could pass them to Crossref and be a better member of the community, and it would also be easier for us to understand our authors.

We could also use RORs for editors and reviewers.

@cthoyt
Copy link
Contributor

cthoyt commented Aug 25, 2024

See openjournals/inara#71 and openjournals/inara#72. I was also thinking about this

@danielskatz
Copy link
Collaborator Author

Thanks very much @cthoyt for your good and complete work!

@danielskatz
Copy link
Collaborator Author

@cthoyt & @xuanxu - We're now having problems accepting papers - see openjournals/joss-reviews#6917 (comment) for example. Is this problem tied to the ROR-related change?

@cthoyt
Copy link
Contributor

cthoyt commented Sep 5, 2024

looking at it now. will give an update in 20-30 minutes

@cthoyt
Copy link
Contributor

cthoyt commented Sep 5, 2024

See openjournals/inara#77, I think I've got a solution

@danielskatz
Copy link
Collaborator Author

👋 @xuanxu & @arfon - Can either of you check this and then potential merge it if that seems appropriate?

@arfon
Copy link
Member

arfon commented Oct 21, 2024

@cthoyt @tarleb – looks like we have a paper using RORs (yay!), but the paper formatting looks pretty janky (see the spacing between affiliations text): https://github.com/openjournals/joss-papers/blob/joss.07377/joss.07377/10.21105.joss.07377.pdf

Any thoughts on how this could be potentially improved?

@cthoyt
Copy link
Contributor

cthoyt commented Oct 21, 2024

yay! and, oh no!

I think this is an artifact of how I turned the ROR SVG into the latex commands. This was a bit of oversight on my part not trying with a more involved author list, but unfortunately when I was making changes to Inara, the diffs were very big and unruly, and I tried to minimize the document changes. I will take a second pass at this, and see if the bounding boxes in the latex commands can be adjusted :)

@cthoyt
Copy link
Contributor

cthoyt commented Oct 22, 2024

hi @arfon, thanks for being patient. I hope I wasn't holding up the daily JOSS grind. I've got a fix in openjournals/inara#90 :)

@cthoyt
Copy link
Contributor

cthoyt commented Oct 23, 2024

hi @arfon, we've merged the fix and made a new 1.1.2 release of Inara that includes it

@tarleb
Copy link
Contributor

tarleb commented Oct 23, 2024

JOSS should make use of the new version once this PR is merged: xuanxu/publishing-artifacts-action#1

@xuanxu
Copy link
Member

xuanxu commented Oct 23, 2024

Merged!

@xuanxu
Copy link
Member

xuanxu commented Oct 23, 2024

PDF regenerated

Before:

Screenshot 2024-10-23 at 15 05 22

After:

Screenshot 2024-10-23 at 15 04 54

@cthoyt
Copy link
Contributor

cthoyt commented Oct 23, 2024

Maybe there's still room for improvement on the vertical positioning and left padding, but this is looking much better already!

@arfon
Copy link
Member

arfon commented Oct 28, 2024

Maybe there's still room for improvement on the vertical positioning and left padding, but this is looking much better already!

😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants