-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROR affiliation links to example paper #1362
Conversation
Thanks @cthoyt - I think this looks good. But I don't think merging this makes sense at this point until we also do something with this information that we'll now sometimes get in the .md papers. Specifically:
|
Another question is if we want this to be optional or required. I lean towards required, but can see arguments both ways. |
@danielskatz the PR I mentioned in the top accomplishes all of the things you requested - it adds ROR links in PDF, it updates Crossref XML generation following their form for annotating affiliation identifiers, and this ultimately gets pulled into JATS. Please take a look at openjournals/inara#72, and if you have any other ideas on functionality, please let me know! Unfortunately, not all affiliations can be annotated with ROR, so I wouldn't enforce a requirement. Though, it's great to have when possible. |
Ok, sorry - I didn't see that this was connected to another PR - I was expecting all of this to happen in a single PR. My mistake... I'll take a look at the whole thing in a little bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Since openjournals/inara#72 has been merged, this is ready to be merged! @arfon would you please do the honors? |
thanks @xuanxu ! |
Closes #1353
In openjournals/inara#72, I added ROR support to Inara such that ROR identifiers can be added to affiliations. They therefore show up with nice icons in the PDF exports, inside the Crossref XML output, and in the JATS output.
As suggested by Arfon in openjournals/inara#72 (comment), I've updated the JOSS documentation to give users a hint on how they can take advantage of this themselves. This PR specifically does the following:
As mentioned in openjournals/inara#72 (comment), there are a few deployment things that need to be done before this is live, but I think we're ready to merge this anyway :)