Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROR affiliation links to example paper #1362

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Sep 2, 2024

Closes #1353

In openjournals/inara#72, I added ROR support to Inara such that ROR identifiers can be added to affiliations. They therefore show up with nice icons in the PDF exports, inside the Crossref XML output, and in the JATS output.

As suggested by Arfon in openjournals/inara#72 (comment), I've updated the JOSS documentation to give users a hint on how they can take advantage of this themselves. This PR specifically does the following:

  • add ROR to example paper
  • update paper guidelines

As mentioned in openjournals/inara#72 (comment), there are a few deployment things that need to be done before this is live, but I think we're ready to merge this anyway :)

@danielskatz
Copy link
Collaborator

Thanks @cthoyt - I think this looks good.

But I don't think merging this makes sense at this point until we also do something with this information that we'll now sometimes get in the .md papers.

Specifically:

  1. We want this to appear in the built PDF
  2. We want this to appear in the built JATS file
  3. (I'm less sure about this) - We want this to be in the metadata (xml file) we submit to Crossref

@danielskatz
Copy link
Collaborator

Another question is if we want this to be optional or required. I lean towards required, but can see arguments both ways.

@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 3, 2024

@danielskatz the PR I mentioned in the top accomplishes all of the things you requested - it adds ROR links in PDF, it updates Crossref XML generation following their form for annotating affiliation identifiers, and this ultimately gets pulled into JATS. Please take a look at openjournals/inara#72, and if you have any other ideas on functionality, please let me know!

Unfortunately, not all affiliations can be annotated with ROR, so I wouldn't enforce a requirement. Though, it's great to have when possible.

@danielskatz
Copy link
Collaborator

Ok, sorry - I didn't see that this was connected to another PR - I was expecting all of this to happen in a single PR. My mistake... I'll take a look at the whole thing in a little bit.

@danielskatz
Copy link
Collaborator

danielskatz commented Sep 3, 2024

Ah, I now see that @arfon and @tarleb have reviewed the other PR - yes, so once that is merged, this seems good to me to be merged too.

Thanks very much for doing this!!

Copy link
Member

@xuanxu xuanxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@arfon
Copy link
Member

arfon commented Sep 4, 2024

:shipit:

@cthoyt cthoyt marked this pull request as ready for review September 4, 2024 21:06
@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 4, 2024

Since openjournals/inara#72 has been merged, this is ready to be merged! @arfon would you please do the honors?

@xuanxu xuanxu merged commit f7a3300 into openjournals:main Sep 5, 2024
1 check passed
@cthoyt cthoyt deleted the patch-1 branch September 5, 2024 09:18
@cthoyt
Copy link
Contributor Author

cthoyt commented Sep 5, 2024

thanks @xuanxu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JOSS and ROR
4 participants