Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fig bug in vertical size of ROR logo #90

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Oct 22, 2024

Motivated by openjournals/joss#1353 (comment)

This removes a vestigial part of the logo that doesn't actually do anything, and in result, gets rid of the weirdly tall characteristic of the ROR logo that caused an issue for longer author lists

In a silly test, I made one of the affiliations very long to show that the spacing is fixed:

Screenshot 2024-10-22 at 15 56 42

This PR also makes a few minor changes:

  1. Fixes the example-doc.yml workflow to build from the current repository, rather than using what's on DockerHub, which is always wrong if you are updating the templates
  2. Fixes a minor typo and formatting issue in the CHANGELOG

@cthoyt cthoyt changed the title Improve spacing in ROR logo Fig bug in vertical size of ROR logo Oct 22, 2024
@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 22, 2024

Hi @tarleb, this fix addresses an issue happening in production for JOSS noticed by @arfon, would you please take a look at this minor bugfix then make a new Inara release? Thanks!

@tarleb
Copy link
Collaborator

tarleb commented Oct 22, 2024

Looks good, thank you! Could squash the logo fixes into a single commit? I'd do a squash merge, but then we'd squash the CI fixes as well, which I'd like to avoid.

@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 22, 2024

@tarleb done - I just rewrote the commit history accordingly

@tarleb tarleb merged commit de44627 into openjournals:main Oct 23, 2024
2 checks passed
@cthoyt cthoyt deleted the fix-ror-logo branch October 23, 2024 12:36
@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 23, 2024

thanks @tarleb !

@tarleb
Copy link
Collaborator

tarleb commented Oct 23, 2024

No, thank you!

@cthoyt cthoyt mentioned this pull request Nov 17, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants