mshr: Prevent assertion misfire during reset #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @paulsc96, Yes, thank you for this PR. I accept it. Could you please accept the Eclipse agreement before I can merge your contribution ? Thank you |
cfuguet
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the cache is held in reset, the
one_command_assertassertion inhpdcache_mshrwill always fail, raising a false-positive error any time the cache is being reset:This should not happen as the reported error is not an actual issue. Furthermore, it presents a problem for testing setups designed to fail on assertion failures, as any meaningful simulation will trigger this assertion.
The proposed fix masks the assertion during reset with the
disable iffclause.