Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps)!: support paragon and frontend-build in openedx scope #457

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

brian-smith-tcril
Copy link
Contributor

BREAKING CHANGE: frontend-platform peer dependency updated to ^7.0.1
BREAKING CHANGE: @edx/paragon peer dependency updated to @openedx/paragon

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dcdaace) 90.61% compared to head (c60a465) 90.61%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   90.61%   90.61%           
=======================================
  Files         228      228           
  Lines        4156     4156           
  Branches      842      842           
=======================================
  Hits         3766     3766           
  Misses        370      370           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated Show resolved Hide resolved
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff for this and the following snapshot look big because they are now wrapped in

      <div data-testid="redux-provider">
        <div data-testid="browser-router">

I believe this came from openedx/frontend-platform#615 - specifically https://github.com/openedx/frontend-platform/blob/8d5d26f2d9b10fa3f39ae76a574d11c4c751df0c/src/react/OptionalReduxProvider.jsx#L16 and https://github.com/openedx/frontend-platform/blob/8d5d26f2d9b10fa3f39ae76a574d11c4c751df0c/src/react/AppProvider.jsx#L77

BREAKING CHANGE: frontend-platform peer dependency updated to ^7.0.1
BREAKING CHANGE: @edx/paragon peer dependency updated to @openedx/paragon
@brian-smith-tcril brian-smith-tcril marked this pull request as ready for review February 9, 2024 15:44
@brian-smith-tcril brian-smith-tcril merged commit f33a3b5 into openedx:main Feb 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants