Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bumped frontend-platform to v6 #456

Conversation

BilalQamar95
Copy link
Contributor

Description:

  • Major version upgrade for frontend-platform
  • Updated snapshots & fixed failing tests

@BilalQamar95 BilalQamar95 self-assigned this Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dcdaace) 90.61% compared to head (fcc9a05) 90.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   90.61%   90.25%   -0.37%     
==========================================
  Files         228      228              
  Lines        4156     4156              
  Branches      842      842              
==========================================
- Hits         3766     3751      -15     
- Misses        370      385      +15     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only updating frontend-platform in devDependencies, it will need to be updated in peerDependencies too.

"@edx/frontend-platform": "^4.0.0 || ^5.0.0",

We also don't have anything in place to test that this will still work with frontend-platform versions < 6, so it may need to be done as a breaking change.

If that's the case, it might make sense to wait for #457 to make the breaking change commit so we don't end up with 2 major version bumps back to back.

@BilalQamar95
Copy link
Contributor Author

Closing since package upgrades of this PR were already taken care of as part of #457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants