Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error handling #1079

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Jun 10, 2024

Description

  • Added alert message if 403 error occurs

@PKulkoRaccoonGang PKulkoRaccoonGang requested a review from a team as a code owner June 10, 2024 13:00
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 10, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 10, 2024

Thanks for the pull request, @PKulkoRaccoonGang!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@PKulkoRaccoonGang PKulkoRaccoonGang changed the title Peter kulko/error handling fix: error handling Jun 10, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/error-handling branch 2 times, most recently from 73319e7 to 557ce04 Compare June 10, 2024 13:04
@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Jun 10, 2024
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but apparently we're getting a whole bunch of MISSING_TRANSLATION errors. I don't remember seeing those before, but I can't readily understand why this PR would trigger them. Any thoughts on that?

@arbrandes
Copy link
Contributor

Also, just realized that there are actual filing tests in there. The MISSING_TRANSLATION ones are filling up the logs (and I'd like to understand why we're getting so many), but apparently that's not why tests are failing.

@PKulkoRaccoonGang
Copy link
Contributor Author

@arbrandes the problem with failing tests is unrelated to MISSING_TRANSLATION. I realized that after my changes one of the tests stopped running successfully.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft June 13, 2024 15:11
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (9b4cf87) to head (c9e7a3a).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1079      +/-   ##
==========================================
+ Coverage   93.01%   93.05%   +0.04%     
==========================================
  Files        1048     1048              
  Lines       20480    20527      +47     
  Branches     4402     4356      -46     
==========================================
+ Hits        19049    19102      +53     
+ Misses       1361     1357       -4     
+ Partials       70       68       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review June 13, 2024 15:48
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's get this in.

@arbrandes
Copy link
Contributor

Looks like we need to fix conflicts.

@KristinAoki
Copy link
Member

@arbrandes is this good to merge or should there be tests be added for the changes?

@mphilbrick211
Copy link

@arbrandes is this good to merge or should there be tests be added for the changes?

@arbrandes - friendly ping on this :)

@arbrandes
Copy link
Contributor

Apologies for the time it took for me to get back here. @KristinAoki is right, there should be tests for the new functionality. @PKulkoRaccoonGang, are you able to tackle that?

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more tests.

@PKulkoRaccoonGang
Copy link
Contributor Author

@arbrandes Yes, we have added this PR to the task list and plan to complete it.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/error-handling branch 2 times, most recently from 9f38b01 to 8b1bbc5 Compare November 6, 2024 19:34
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft November 6, 2024 19:50
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/error-handling branch 5 times, most recently from bbd5e1c to ca1c499 Compare November 11, 2024 16:16
@PKulkoRaccoonGang PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Nov 12, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review November 12, 2024 08:43
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@PKulkoRaccoonGang PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Nov 12, 2024
@regisb
Copy link
Contributor

regisb commented Nov 15, 2024

It appears that this PR will fix this issue, right?

@PKulkoRaccoonGang
Copy link
Contributor Author

@regisb yes, thanks 👍

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's get this in, second attempt. ;)

@arbrandes arbrandes merged commit 0706a09 into openedx:master Nov 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants