-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error handling #1079
fix: error handling #1079
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
73319e7
to
557ce04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but apparently we're getting a whole bunch of MISSING_TRANSLATION
errors. I don't remember seeing those before, but I can't readily understand why this PR would trigger them. Any thoughts on that?
Also, just realized that there are actual filing tests in there. The |
@arbrandes the problem with failing tests is unrelated to |
70fdcda
to
702aee3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
+ Coverage 93.01% 93.05% +0.04%
==========================================
Files 1048 1048
Lines 20480 20527 +47
Branches 4402 4356 -46
==========================================
+ Hits 19049 19102 +53
+ Misses 1361 1357 -4
+ Partials 70 68 -2 ☔ View full report in Codecov by Sentry. |
702aee3
to
6752733
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's get this in.
Looks like we need to fix conflicts. |
6752733
to
03fe379
Compare
@arbrandes is this good to merge or should there be tests be added for the changes? |
@arbrandes - friendly ping on this :) |
Apologies for the time it took for me to get back here. @KristinAoki is right, there should be tests for the new functionality. @PKulkoRaccoonGang, are you able to tackle that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs more tests.
@arbrandes Yes, we have added this PR to the task list and plan to complete it. |
9f38b01
to
8b1bbc5
Compare
8b1bbc5
to
aa3fa95
Compare
bbd5e1c
to
ca1c499
Compare
ca1c499
to
c9e7a3a
Compare
Sandbox deployment failed 💥 |
It appears that this PR will fix this issue, right? |
@regisb yes, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's get this in, second attempt. ;)
Description