fix: fixed tests

openedx · Nov 6, 2024 · 8b1bbc5 · 8b1bbc5
1 parent d4c81b1
commit 8b1bbc5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 69 deletions.
diff --git a/src/course-checklist/CourseChecklist.jsx b/src/course-checklist/CourseChecklist.jsx
@@ -37,10 +37,10 @@ const CourseChecklist = ({
     bestPracticeData,
   } = useSelector(state => state.courseChecklist);
 
-  const { bestPracticeChecklistStatus, launchChecklistStatus } = loadingStatus;
+  const { bestPracticeChecklistLoadingStatus, launchChecklistLoadingStatus, launchChecklistStatus } = loadingStatus;
 
-  const isCourseLaunchChecklistLoading = bestPracticeChecklistStatus === RequestStatus.IN_PROGRESS;
-  const isCourseBestPracticeChecklistLoading = launchChecklistStatus === RequestStatus.IN_PROGRESS;
+  const isCourseLaunchChecklistLoading = bestPracticeChecklistLoadingStatus === RequestStatus.IN_PROGRESS;
+  const isCourseBestPracticeChecklistLoading = launchChecklistLoadingStatus === RequestStatus.IN_PROGRESS;
   const isLoadingDenied = launchChecklistStatus === RequestStatus.DENIED;
 
   if (isLoadingDenied) {

diff --git a/src/course-outline/data/thunk.js b/src/course-outline/data/thunk.js
@@ -102,7 +102,6 @@ export function fetchCourseOutlineIndexQuery(courseId) {
       if (error.response && error.response.status === 403) {
         dispatch(updateOutlineIndexLoadingStatus({
           status: RequestStatus.DENIED,
-          errors: getErrorDetails(error, false),
         }));
       } else {
         dispatch(updateOutlineIndexLoadingStatus({

diff --git a/src/grading-settings/GradingSettings.jsx b/src/grading-settings/GradingSettings.jsx
@@ -8,6 +8,7 @@ import {
   useGradingSettings,
   useGradingSettingUpdater,
 } from 'CourseAuthoring/grading-settings/data/apiHooks';
+import { RequestStatus } from 'CourseAuthoring/data/constants';
 import PropTypes from 'prop-types';
 import React, { useEffect, useState } from 'react';
 import { Helmet } from 'react-helmet';
@@ -47,8 +48,7 @@ const GradingSettings = ({ courseId }) => {
 
   const courseAssignmentLists = gradingSettings?.courseAssignmentLists;
   const courseGradingDetails = gradingSettings?.courseDetails;
-
-  const isLoadingDenied = loadingStatus === RequestStatus.DENIED;
+  const isLoadingDenied = isCourseSettingsLoading === RequestStatus.DENIED;
   const [showSuccessAlert, setShowSuccessAlert] = useState(false);
   const isLoading = isCourseSettingsLoading || isGradingSettingsLoading;
   const [isQueryPending, setIsQueryPending] = useState(false);

diff --git a/src/grading-settings/data/thunks.js b/src/grading-settings/data/thunks.js