Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added notification preferences settings at account level #1159

Merged
merged 10 commits into from
Dec 31, 2024

refactor: refactor code

5228cc9
Select commit
Loading
Failed to load commit list.
Merged

feat: added notification preferences settings at account level #1159

refactor: refactor code
5228cc9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 27, 2024 in 1s

57.99% (-0.64%) compared to f86261d

View this Pull Request on Codecov

57.99% (-0.64%) compared to f86261d

Details

Codecov Report

Attention: Patch coverage is 52.50000% with 38 lines in your changes missing coverage. Please review.

Project coverage is 57.99%. Comparing base (f86261d) to head (5228cc9).
Report is 7 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/notification-preferences/data/thunks.js 12.50% 17 Missing and 4 partials ⚠️
...cation-preferences/NotificationCoursesDropdown.jsx 72.72% 5 Missing and 1 partial ⚠️
src/notification-preferences/data/service.js 16.66% 5 Missing ⚠️
src/divider/Divider.jsx 0.00% 4 Missing ⚠️
src/notification-preferences/data/actions.js 50.00% 1 Missing ⚠️
src/notification-preferences/data/reducers.js 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           2u-main    #1159      +/-   ##
===========================================
- Coverage    58.62%   57.99%   -0.64%     
===========================================
  Files          117      119       +2     
  Lines         2335     2376      +41     
  Branches       643      655      +12     
===========================================
+ Hits          1369     1378       +9     
- Misses         905      931      +26     
- Partials        61       67       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov