Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added notification preferences settings at account level #1159

Merged
merged 10 commits into from
Dec 31, 2024

Conversation

awais-ansari
Copy link
Contributor

INF-1688

Description

  • Update the notification preferences UI according to the above figma design. The account level preference option does not need to be implemented in this ticket. The course level preferences should be implemented.

Figma

Screenshot 2024-11-14 at 1 44 20 PM

MFE Account

Screenshot 2024-11-14 at 1 51 36 PM

@sundasnoreen12 sundasnoreen12 force-pushed the aansari/INF-1688 branch 2 times, most recently from e89c6a6 to 301797a Compare November 19, 2024 11:15
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 52.50000% with 38 lines in your changes missing coverage. Please review.

Project coverage is 57.99%. Comparing base (f86261d) to head (5228cc9).
Report is 8 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/notification-preferences/data/thunks.js 12.50% 17 Missing and 4 partials ⚠️
...cation-preferences/NotificationCoursesDropdown.jsx 72.72% 5 Missing and 1 partial ⚠️
src/notification-preferences/data/service.js 16.66% 5 Missing ⚠️
src/divider/Divider.jsx 0.00% 4 Missing ⚠️
src/notification-preferences/data/actions.js 50.00% 1 Missing ⚠️
src/notification-preferences/data/reducers.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1159      +/-   ##
===========================================
- Coverage    58.62%   57.99%   -0.64%     
===========================================
  Files          117      119       +2     
  Lines         2335     2376      +41     
  Branches       643      655      +12     
===========================================
+ Hits          1369     1378       +9     
- Misses         905      931      +26     
- Partials        61       67       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@awais-ansari awais-ansari merged commit 6f6cf7c into 2u-main Dec 31, 2024
6 of 8 checks passed
@awais-ansari awais-ansari deleted the aansari/INF-1688 branch December 31, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants