-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FC-0068 docs: concept cleaning by edunext #11 #716
base: main
Are you sure you want to change the base?
FC-0068 docs: concept cleaning by edunext #11 #716
Conversation
Thanks for the pull request, @BryanttV! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
4099749
to
6d08a6c
Compare
6d08a6c
to
1a9439b
Compare
@BryanttV is this ready for review? |
Hi @sarina, yeah, this is ready. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only reviewed the first file. Please take a look through my comments, and update following documents appropriately before requesting a re-review. Particularly, "Open edX" should be used as an adjective, should not be capitalized as "Open Edx", and some judgement should be applied when to use something like "your Open edX instance" or simply "your instance".
source/educators/concepts/advanced_features/lti_reuse_content.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/advanced_features/lti_reuse_content.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/advanced_features/lti_reuse_content.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/advanced_features/lti_reuse_content.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/advanced_features/lti_reuse_content.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/advanced_features/lti_reuse_content.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/advanced_features/lti_reuse_content.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/advanced_features/lti_reuse_content.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/advanced_features/lti_reuse_content.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/advanced_features/lti_reuse_content.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/advanced_features/teams_learner_experience.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/exercise_tools/OpenResponseAssessments.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/exercise_tools/OpenResponseAssessments.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/exercise_tools/OpenResponseAssessments.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/exercise_tools/OpenResponseAssessments.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/exercise_tools/OpenResponseAssessments.rst
Outdated
Show resolved
Hide resolved
If you include a staff assessment step, it should be the final step in the | ||
assignment. | ||
assessment steps. If you include both peer and self assessment steps, Open | ||
edX recommends that you place the peer assessment before the self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace Open edX as the subject with Open edX Community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually say, "... self assessment steps, it is recommended that you place..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: c87cb85
f7fe914
to
9eac14c
Compare
:ref:`Example: edX as an LTI Provider to Blackboard<edX as an LTI Provider to Blackboard>` (reference) | ||
|
||
:ref: `edX as an LTI Provider to Canvas` (reference) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this reference and why is it not Open edX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reference is the Open edX repository, but the tag name of that file wasn't modified to prevent the broken links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the references to use the correct tags: 4daafbe. Thanks!
near real time. It can take a few moments to complete this exchange for a | ||
single problem component, and up to several minutes to return aggregated scores | ||
of all of the problems in a unit or subsection. | ||
When you include the problem components in a graded Open edX subsection in an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rewrite this paragraph because it is confusing, it talks about "Open edX" as a thing when really it needs to be discussing your specific Open edX instance.
When you include problem components from a graded subsection in your Open edX instance in an external LMS, your Open edX instance will grade the learner responses to those problems. Your instance then transfers the learner scores back to the external LMS. This exchange between an external LMS, your Open edX instance, and the external LMS again is near real time. It can take a few moments to complete this exchange for a single problem component, and up to several minutes to return aggregated scores of all the problems in a unit or subsection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!, I applied your suggestion: 1d2621d
|
||
When you include edX problem components in an external LMS, note the following | ||
requirements. | ||
When you include Open edX problem components in an external LMS, note the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you include Open edX problem components in an external LMS, note the | |
When you include problem components from your Open edX instance in an external LMS, note the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: 1d2621d
|
||
* The edX problem component must be in one of the graded subsections in your | ||
course. | ||
* The Open edX problem component must be in one of the graded subsections in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* The Open edX problem component must be in one of the graded subsections in | |
* The problem component must be in one of the graded subsections in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: 1d2621d
:ref: `edX as an LTI Provider to Canvas` (reference) | ||
|
||
:ref: `edX as an LTI Provider to Blackboard` (reference) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the references to use the correct tags: 4daafbe. Thanks!
recommends that you make ORA assignments count towards only a small | ||
percentage of a course's final grade. | ||
.. note:: Given the high level of subjectivity in peer assessments, the Open | ||
edX Community recommends that you make ORA assignments count towards only a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edX Community recommends that you make ORA assignments count towards only a | |
it is recommended that you make ORA assignments count towards only a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: c87cb85
@@ -555,8 +539,8 @@ assignment. | |||
You can allow the **Top Responses** section to show between 1 and 100 | |||
responses. Keep in mind, however, that each response might be up to 300 pixels | |||
in height in the list. (For longer responses, learners can scroll to see the | |||
entire response.) EdX recommends that you specify 20 or fewer responses to | |||
prevent the page from becoming too long. | |||
entire response.) The Open edX Community recommends that you specify 20 or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
entire response.) The Open edX Community recommends that you specify 20 or | |
entire response.) It is recommended that you specify 20 or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: c87cb85
@@ -586,12 +568,12 @@ correct or incorrect answers to questions. | |||
.. note:: Do not add more than one ORA component in a course unit. Multiple ORA | |||
assignments in a unit cause errors when learners submit their assessments. | |||
|
|||
EdX suggests that you follow the guidelines and best practices in the | |||
following sections when you use open response assessments in your courses. | |||
The Open edX Community suggests that you follow the guidelines and best |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Open edX Community suggests that you follow the guidelines and best | |
It is suggested that you follow the guidelines and best |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: c87cb85
maintained by the development operations team at edX, and are subject to | ||
change. | ||
Learners cannot upload file types with the following file name extensions as | ||
part of and Open Response Assessment. When you define a set of custom file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
part of and Open Response Assessment. When you define a set of custom file | |
part of an Open Response Assessment. When you define a set of custom file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: c87cb85
part of and Open Response Assessment. When you define a set of custom file | ||
types for learners to upload with their responses, you cannot specify them. The | ||
extensions on this list are selected and maintained by the development | ||
operations team at the Open edX Community and are subject to change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't true, there isn't a development operations team within the community. I'm not sure how this list is defined or maintained so I would simply remove this entire last sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: c87cb85
d88c241
to
1d2621d
Compare
a set of custom file types for learners to upload with their responses, you | ||
cannot specify these file types. The extensions on this list are selected and | ||
maintained by the development operations team at edX, and are subject to | ||
change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please only remove the last sentence ("The extensions on this list are selected and
maintained by the development operations team at edX, and are subject to
change."), not the whole paragraph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: 72a1b1d
This PR modifies a series of concept documents migrated from the legacy repositories to the educators' documentation.