Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip empty transmitting in line summaries when paused #2427

Merged

Conversation

dexonsmith
Copy link
Contributor

f2ebda3 and b2f2565 already tightened up the display of line summaries for games that are NOT paused by removing the <span> for transmitting.

This follow-up also removes the span when the game IS paused. Otherwise, a blank line is added on really small screens (e.g., mobile), when the empty transmitting <span> and the word "Paused" don't fit on one line.

Fixes #2426

f2ebda3 and b2f2565 already tightened up the display of line
summaries for games that are NOT paused by removing the `<span>` for
`transmitting`.

This follow-up also removes the span when the game IS paused. Otherwise, a
blank line is added on really small screens (e.g., mobile), when the empty
transmitting `<span>` and the word "Paused" don't fit on one line.
Copy link

github-actions bot commented Nov 17, 2023

Uffizzi Preview deployment-41017 was deleted.

@dexonsmith
Copy link
Contributor Author

Before:
Before
After:
After

@anoek anoek merged commit 141841e into online-go:devel Nov 27, 2023
4 checks passed
@dexonsmith dexonsmith deleted the skip-empty-transmitting-in-line-summary branch November 28, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List entries for paused games take extra vertical space on mobile
2 participants