Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List entries for paused games take extra vertical space on mobile #2426

Closed
dexonsmith opened this issue Nov 17, 2023 · 6 comments · Fixed by #2427
Closed

List entries for paused games take extra vertical space on mobile #2426

dexonsmith opened this issue Nov 17, 2023 · 6 comments · Fixed by #2427

Comments

@dexonsmith
Copy link
Contributor

Describe the bug
A follow-up issue for #2418 -- turns out that paused games were using extra vertical space for a related reason, and #2420 didn't fix this.

To reproduce:

  1. Create enough active games to require a game list
  2. Pause one
  3. Make your screen small (e.g., use mobile)
  4. Observe the blank line between the time on the actual clock time and the word "Pause" in "Clock" column.
@dexonsmith
Copy link
Contributor Author

PR is #2427. Let me know if I should have just sent that (i.e., was it worth me writing up this issue?).

@benjaminpjones
Copy link
Contributor

Let me know if I should have just sent that (i.e., was it worth me writing up this issue?)

I think issues can be valuable for tracking, but they aren't strictly necessary - there are plenty of PRs that do not have issues attached.

One thing I do think would be helpful for these cosmetic fixes would be before and after screenshots - would save quite a few clicks to understand the end result :)

@dexonsmith
Copy link
Contributor Author

One thing I do think would be helpful for these cosmetic fixes would be before and after screenshots - would save quite a few clicks to understand the end result :)

Makes sense, of course, and happy to do it!

... Any chance you could point me at how/where I might host the screenshots? (My reflexes are twenty years out-of-date for web stuff... I feel like the answer should be obvious these days, but I don't know what it is.)

@benjaminpjones
Copy link
Contributor

No need to worry about hosting, GitHub takes care of it :) you should be able to click and drag photos into the text box or click the Attach Files button.

Screenshot showing the Attach File button

https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/attaching-files

@dexonsmith
Copy link
Contributor Author

(Added the before/after to the PR.)

@dexonsmith
Copy link
Contributor Author

No need to worry about hosting, GitHub takes care of it :) you should be able to click and drag photos into the text box or click the Attach Files button.

And I was right... the answer was obvious :). (Thanks!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants