make it work with browserify #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main issue preventing browserify usage was computed paths
in require statements: `require("./" + someVariable)`. Those have
all been eliminated.
This patch only adds browser support for `v3.0.0` (see the throwing
code in `/index.js` where it states exactly that to understand why).
Hint: it's related to computed paths again.
There were also a number of issues in `browserify-http`, and
`browserify-https` that I needed to code around to get things working:
- https://github.com/substack/https-browserify/pull/1
- browserify/http-browserify#90
- browserify/http-browserify#21
- browserify/http-browserify#10
| @@ -19,7 +19,7 @@ var error = require("./../../error"); | |||
|
|
|||
| var GithubHandler = module.exports = function(client) { | |||
| this.client = client; | |||
| this.routes = JSON.parse(Fs.readFileSync(__dirname + "/routes.json", "utf8")); | |||
| this.routes = require("./routes.json"); | |||
There was a problem hiding this comment.
Reading a file via the fs module is not well supported in browserify without a special transform.
Fortunately for json files we can just require() them and it works across platforms.
|
Anyone wishing to use my patched version can install it with the following command:
You can then use it like you normally would server side. (you still just |
This was referenced Jun 30, 2015
|
@mikedeboer Any chance we can get this work re-started? I would love Browserify support for this package. Any reason why this was never merged? I don't mind doing the work to make it mergeable again. |
|
Yeah I've been backlogged with stuff, but it's on my radar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue preventing browserify usage was computed paths
in require statements:
require("./" + someVariable). Those haveall been eliminated.
This patch only adds browser support for
v3.0.0(see the throwingcode in
/index.jswhere it states exactly that to understand why).Hint: it's related to computed paths again.
There were also a number of issues in
browserify-http, andbrowserify-httpsthat I needed to code around to get things working:res.setEncodingand non-text response types browserify/http-browserify#21