Not browserify compatible

[rgiard]

Not sure we should mark it has an issue, but it is not possible to browserify the module (http://browserify.org/). Using variables in "require(...)" and reading the routes from a file is not browserify safe. Just raising the point ...

[feltnerm]

Would ❤️ if this library was browserify-able. I was able to achieve success by modifying code from #121 (I also had to patch http-browserify to not send credentials on HTTPS to avoid CORS errors).

I'd be willing to work on this if there was interest, and @mikedeboer was interested in reviewing for me.

[rgiard]

Oh Thanks @feltnerm ! Let me check your work. Still, it would be nice to have the module browserify compatible :)

[piranna]

Any update on this? I'm also interested on access GitHub API from browser...

[revolunet]

+1

[jamestalmage]

I have browser support working. See #261

Until @mikedeboer merges, you can install my patch via:
npm install --save jamestalmage/node-github#browserify-compatibility

[jwickens]

+1 would be great if the patch was merged to master

[gr2m]

@jamestalmage note that browserify-compatibility branch no longer exist. Is it maybe browserify-and-promises now?

npm install --save jamestalmage/node-github#browserify-and-promises

I tried to browsery using your fork, but got Error: Cannot find module './api/vundefined'. Do you have a built somewhere you can share?

[gr2m]

update: browser compatibility is the next big milestone. I recommend to subscribe to this issue to stay up-to-date: #620

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[gr2m]

The latest release of @octokit/rest is compatible with browserify. See more news regarding browser support in my latest update: https://github.com/octokit/rest.js/issues/620#issuecomment-362715478

I recommend to subscribe to issue #620 to stay up-to-date with all things JavaScript Octokit :)