Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cordova app Android, iOS + audio support #45

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Cordova app Android, iOS + audio support #45

wants to merge 12 commits into from

Conversation

mohammad-haque
Copy link
Collaborator

Audio playback feature works and tested in Android and iOS. As there are no UI at the moment only way to test is from debug console. Please see details in ReadMe file.

I have added audio helper js in index.html and I'm not sure this would be idea for web app?

@oazabir
Copy link
Owner

oazabir commented Nov 2, 2015

Many thanks for doing this. I need to setup an android dev env. I will get
back.

Is there a way you can integrate the web UI into an App, make the player
play a verse, and I can just run the app without setting up a full dev env?

On Sun, Nov 1, 2015 at 2:13 PM, Mohammad Haque [email protected]
wrote:

Audio playback feature works and tested in Android and iOS. As there are
no UI at the moment only way to test is from debug console. Please see
details in ReadMe file.

I have added audio helper js in index.html and I'm not sure this would be

idea for web app?

You can view, comment on, or merge this pull request online at:

#45
Commit Summary

  • updated gitignore
  • basic cordova app with android plugin
  • updated config for android plugin
  • added audio downloader/player helper
  • minor refactoring
  • removed old android project
  • added audio helper js in main source repo
  • Merge branch 'master' into cordova
  • refactored audio player helper
  • added read me file
  • updated read me

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#45.

OmarALZabir.com/Charity

@mohammad-haque
Copy link
Collaborator Author

@oazabir Not sure I follow you. Did you mean build the app and send it you?

@oazabir
Copy link
Owner

oazabir commented Nov 3, 2015

Yes, some way I can run the app directly on my mac without building,
compiling etc.

On Mon, Nov 2, 2015 at 10:05 PM, Mohammad Haque [email protected]
wrote:

@oazabir https://github.com/oazabir Not sure I follow you. Did you mean
build the app and send it you?

—
Reply to this email directly or view it on GitHub
#45 (comment).

OmarALZabir.com/Charity

@mohammad-haque
Copy link
Collaborator Author

Ok, I can commit the APK for android which you can run in emulator.

In terms of playing audio I think we need some sort of UI that will initiate recitation from certain place (long press on aya for example). Are you planning to to add something like?

@oazabir
Copy link
Owner

oazabir commented Nov 4, 2015

Let me build some UI.

Maybe for now you could experiment with hooking click even on the ayah
number:

$('.ayah_number').click(function() {
alert('clicked');
});

On Tue, Nov 3, 2015 at 8:56 PM, Mohammad Haque [email protected]
wrote:

Ok, I can commit the APK for android which you can run in emulator.

In terms of playing audio I think we need some sort of UI that will
initiate recitation from certain place (long press on aya for example). Are
you planning to to add something like?

—
Reply to this email directly or view it on GitHub
#45 (comment).

OmarALZabir.com/Charity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammad-haque @oazabir @shumin