Add new hashing functions (SHA & Keccak) #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the Snarky type definition file to support SHA hashing and conversion from hex to field bytes.
…ccak256 hash functions
…on, default and Keccack256
Closed
Trivo25
reviewed
Jun 26, 2023
Closed
…nstead of a Field array
… to UInt8 array using Snarky.sha library
…ray of UInt8 to a hex string
…ersion for SHA224, SHA256, SHA384, SHA512, and Keccack256 hash functions. Add helper functions to check the conversion and compare the digests.
…thods to UInt8 class for better usability and serialization
Co-authored-by: jackryanservia <[email protected]>
Co-authored-by: jackryanservia <[email protected]>
Co-authored-by: jackryanservia <[email protected]>
Co-authored-by: jackryanservia <[email protected]>
Co-authored-by: jackryanservia <[email protected]>
Co-authored-by: jackryanservia <[email protected]>
Co-authored-by: jackryanservia <[email protected]>
|
new bindings: o1-labs/o1js-bindings#220 |
|
Another idea for |
Trivo25
approved these changes
Dec 14, 2023
| @@ -2150,4 +2137,897 @@ describe('int', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
one day i will refactor this file to save us 3k of lines :D
| @@ -525,6 +525,7 @@ declare const Snarky: { | |||
| }; | |||
| }; | |||
|
|
|||
| // TODO: implement in TS | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements o1-labs/rfcs#9
This PR adds support for hashing using various SHA algorithms and Keccak. The OCaml bindings expose the base functionality, which calls into Kimchi.
To see example usage, see the following tests:
Unit tests: https://github.com/o1-labs/snarkyjs/pull/999/files#diff-772a0ee5ba611c22e73c36051c7139a50869713a53c357d2f6abb49abfbfa497
Integration test: https://github.com/o1-labs/snarkyjs/pull/999/files#diff-1f506bf5891efbbfba747df80700012d212be51e402f9f406e21155992858664
Note: Hashing only works for Field variables. No hashing is implemented for constant fields, which can lead to errors if users try to hash outside of a provable method. We can add a lightweight JS dependency that implements SHA/Keccak hashing and convert our constant Field values into something the JS dependency expects.
Currently waiting on 🔗 MinaProtocol/mina#12524 to be merged for proving to be enabled.
🔗 Bindings o1-labs/o1js-bindings#53