Add new hashing functions (SHA & Keccak) #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport SHA3 hashing in JS bindings
MartinMinkov
force-pushed
the
feat/add-sha
branch
from
fb98a54
to
ec89821
Compare
…odule for checking if a value is less than a specified number of bits
MartinMinkov
commented
Jul 5, 2023
| @@ -8,6 +8,10 @@ module Poseidon : sig | |||
| type sponge | |||
| end | |||
|
|
|||
| (** | |||
| This type definition is copy/pasted from the `snarkyjs_bindings.ml` using an LSP to see the type definition of `snarky`. | |||
There was a problem hiding this comment.
Is this the best way to describe how to add to this type? 🤔
|
|
||
| let check_bits value bits = | ||
| Kimchi_gadgets.Lookup.less_than_bits (module Impl) ~bits value ; | ||
| Kimchi_gadgets.Range_check.bits64 (module Impl) Impl.Field.zero |
There was a problem hiding this comment.
The reason for calling Kimchi_gadgets.Range_check.bits64 is because less_than_bits expects a "dummy gate" to be initialized before calling it (as noted here). Calling this every time check_bits is called seems wasteful, is there a better way to initialize the range check once?
|
superseded by o1-labs/o1js#1291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements o1-labs/rfcs#9
This PR adds support for hashing using various SHA algorithms and Keccak that is exposed in the OCaml bindings to be used by SnarkyJS. This is the layer in which the calls to Kimchi are made.
🔗 SnarkyJS o1-labs/o1js#999