Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable chrome tests #16424

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Reenable chrome tests #16424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5cfd88a
Reenable chrome tests
seanbudd Apr 18, 2024
fb9d259
Merge remote-tracking branch 'origin/master' into reEnableChromeTests
seanbudd Jun 12, 2024
9d39ab8
add no first run flag
seanbudd Jun 12, 2024
88b79f0
add more flags
seanbudd Jun 12, 2024
32fb092
remove certain flags
seanbudd Jun 12, 2024
e7a1be4
disable broken tests
seanbudd Jun 12, 2024
6bc42c8
fix up exclusions
seanbudd Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/system/libraries/_chromeArgs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@ def getChromeArgs() -> str:
"""
return (
"chrome" # Start Chrome
" --no-first-run" # Don't show intro pages for the first run of chrome
" --force-renderer-accessibility" # don't rely on chrome detecting a screen reader.
" --ash-no-nudges" # Prevents Chrome from showing nudge messages.
" --browser-test" # Enable browser test mode, helps reduce flakey tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anymore info you can provide on how it reduces flaky tests? all in same process, or reduces UI clutter...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much info from chrome here just the following:

Tells whether the code is running browser tests (this changes the startup URL used by the content shell and also disables features that can make tests flaky [like monitoring of memory pressure])

https://peter.sh/experiments/chromium-command-line-switches/#browser-test

" --disable-default-apps" # Don't show default apps on the new tab page.
" --keep-alive-for-test" # Reduces start/stop time by keeping the app alive with no windows open.
" --suppress-message-center-popups" # prevent popups that may interfere with automated tests.
" --disable-notifications" # prevent notifications that may interfere with automated tests.
" --no-experiments" # Stable behavior is preferred.
Expand Down
8 changes: 7 additions & 1 deletion tests/system/robot/chromeTests.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# For more details see: https://www.gnu.org/licenses/gpl-2.0.html
*** Settings ***
Documentation HTML test cases in Chrome
Force Tags NVDA smoke test browser chrome excluded_from_build
Force Tags NVDA smoke test browser chrome

# for start & quit in Test Setup and Test Test Teardown
Library NvdaLib.py
Expand Down Expand Up @@ -91,12 +91,16 @@ ARIA roleDescription focus
ARIA roleDescription inline browse mode
[Documentation] Read an inline element with a custom role in browse mode
test_ariaRoleDescription_inline_browseMode
# Disabled due to chrome message "To get missing image descriptions, open the context menu."
[Tags] excluded_from_build
ARIA roleDescription block browse mode
[Documentation] Read a block element with a custom role in browse mode
test_ariaRoleDescription_block_browseMode
# Disabled due to chrome message "To get missing image descriptions, open the context menu."
ARIA roleDescription inline content editable
[Documentation] Read an inline element with a custom role in content editables
test_ariaRoleDescription_inline_contentEditable
[Tags] excluded_from_build
ARIA roleDescription block content editable
[Documentation] Read an block element with a custom role in content editables
test_ariaRoleDescription_block_contentEditable
Expand Down Expand Up @@ -159,9 +163,11 @@ i13307
textParagraphNavigation
[Documentation] Text paragraph navigation
test_textParagraphNavigation
[Tags] excluded_from_build
styleNav
[Documentation] Same style navigation
test_styleNav
[Tags] excluded_from_build
aria-errormessage
[Documentation] Test that aria-errormessage is reported correctly in focus and browse mode
test_ariaErrorMessage