Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable chrome tests #16424

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Reenable chrome tests #16424

merged 7 commits into from
Jun 13, 2024

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Apr 18, 2024 •
edited
Loading

Closes #16135

Summary by CodeRabbit

  • New Features

    • Enhanced Chrome command-line arguments to improve testing efficiency and stability .

  • Tests

    • Re-enabled several test cases related to ARIA role descriptions and navigation in Chrome, improving test coverage.

@seanbudd seanbudd added this to the 2024.2 milestone Apr 18, 2024
@AppVeyorBot
Copy link

See test results for failed build of commit 991031dc31

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 23, 2024
@AppVeyorBot
Copy link

See test results for failed build of commit ad186d95ec

@AppVeyorBot
Copy link

See test results for failed build of commit eb71390596

@AppVeyorBot
Copy link

See test results for failed build of commit acb9efa53b

@AppVeyorBot
Copy link

See test results for failed build of commit 925fef8027

@seanbudd
Copy link
Member Author

@mltony I've had to disable two of your tests to re-enable chrome testing. Could you look into fixing these up?
The problematic tests are styleNav and textParagraphNavigation

Example failure: https://ci.appveyor.com/project/NVAccess/nvda/builds/50001460/tests

@seanbudd seanbudd removed this from the 2024.2 milestone Jun 12, 2024
@AppVeyorBot
Copy link

See test results for failed build of commit 11047fbec2

@seanbudd seanbudd marked this pull request as ready for review June 12, 2024 06:35
@seanbudd seanbudd requested a review from a team as a code owner June 12, 2024 06:35
@seanbudd seanbudd requested a review from SaschaCowley June 12, 2024 06:35
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 12, 2024 •
edited
Loading

Walkthrough

The recent updates enhance the getChromeArgs function by adding new command-line arguments to optimize Chrome's behavior for testing. Additionally, certain ARIA role description and navigation test cases in the ChromeTests suite have been re-enabled by removing the excluded_from_build tag, aiming to ensure comprehensive test coverage.

Changes

Files Change Summary
tests/system/libraries/_chromeArgs.py Added new command-line arguments (--no-first-run, --ash-no-nudges, --browser-test, --disable-default-apps, --keep-alive-for-test) to getChromeArgs.
tests/system/robot/chromeTests.robot Removed excluded_from_build tag from several test cases related to ARIA role descriptions and navigation to re-enable them.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Re-enable chrome tests disabled in #16127 (#16135) ✅
Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d7facd1 and 6bc42c8.

Files selected for processing (2)
  • tests/system/libraries/_chromeArgs.py (1 hunks)
  • tests/system/robot/chromeTests.robot (3 hunks)
Additional context used
Path-based instructions (2)
tests/system/libraries/_chromeArgs.py (2)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Pattern **/*.py: _, pgettext, ngettext, and ngettext are defined globally, errors for this being undefined can be ignored.

tests/system/robot/chromeTests.robot (1)

Pattern **/*: Focus on code smells, logic errors, edge cases, missing test cases, security flaws and serious issues. Avoid commenting on minor issues such as linting, formatting and style issues. This project uses tabs instead of spaces, do not suggest usage of spaces over tabs. Are there any 'red flags' in this code that might warrant closer investigation from a security standpoint? Explain what makes them suspicious.

Additional comments not posted (3)
tests/system/libraries/_chromeArgs.py (1)

17-22: The added command-line arguments enhance the control over Chrome's behavior during automated tests, which is crucial for consistent test results. Ensure these arguments align with the intended test scenarios.

tests/system/robot/chromeTests.robot (2)

94-95: The removal of the excluded_from_build tag from these tests indicates readiness for inclusion in the build process. However, ensure that the issues leading to their previous exclusion have been resolved.

Also applies to: 99-99, 103-103, 166-166, 170-170

7-7: The updated tags reflect the re-inclusion of these tests in the build process. Verify that the tests are stable and do not introduce flakiness in the CI pipeline.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mltony
Copy link
Contributor

mltony commented Jun 12, 2024

@seanbudd, will take a look this weekend.

michaelDCurran
michaelDCurran reviewed Jun 13, 2024
View reviewed changes
tests/system/libraries/_chromeArgs.py
" --force-renderer-accessibility" # don't rely on chrome detecting a screen reader.
" --ash-no-nudges" # Prevents Chrome from showing nudge messages.
" --browser-test" # Enable browser test mode, helps reduce flakey tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anymore info you can provide on how it reduces flaky tests? all in same process, or reduces UI clutter...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much info from chrome here just the following:

Tells whether the code is running browser tests (this changes the startup URL used by the content shell and also disables features that can make tests flaky [like monitoring of memory pressure])

https://peter.sh/experiments/chromium-command-line-switches/#browser-test

@seanbudd seanbudd merged commit ad9ed73 into master Jun 13, 2024
3 checks passed
@seanbudd seanbudd deleted the reEnableChromeTests branch June 13, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelDCurran michaelDCurran michaelDCurran approved these changes

@SaschaCowley SaschaCowley Awaiting requested review from SaschaCowley SaschaCowley is a code owner automatically assigned from nvaccess/developers

Assignees
No one assigned
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable chrome tests
4 participants
@seanbudd @AppVeyorBot @mltony @michaelDCurran