-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: Improve testing and increase coverage #636
base: master
Are you sure you want to change the base?
Commits on Nov 18, 2024
-
client: Increase coverage for
Dial
methodOne of the added tests fails: it is planned to be corrected in the future. Signed-off-by: Leonard Lyubich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 56b1f15 - Browse repository at this point
Copy the full SHA 56b1f15View commit details -
client: Do not lose some URI parsing failure reasons on dial
Previously, `Client.Dial` lost causing error of network endpoint parsing. Although the method returned "invalid endpoint options" error, the original reason could not be obtained. This made debugging difficult. Now causes are kept and returned. For this, function `WithNetworkURIAddress` is inlined and the `ParseURI` error is not ignored. Fixes one of the corresponding tests. Signed-off-by: Leonard Lyubich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1a3a6e5 - Browse repository at this point
Copy the full SHA 1a3a6e5View commit details -
client: Place URI parsing function from neofs-api-go module internally
The function is placed inside the lib to facilitate its support and as a preliminary preparation for the obsolescence of `github.com/nspcc-dev/neofs-api-go/v2` module. Signed-off-by: Leonard Lyubich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b98a39b - Browse repository at this point
Copy the full SHA b98a39bView commit details -
internal/util: Drop wrong statement from
ParseURI
func docsThe function return zeros on multiaddr input. Signed-off-by: Leonard Lyubich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b8377f9 - Browse repository at this point
Copy the full SHA b8377f9View commit details -
client: Do not try to dial an invalid server endpoint
Previously, `Client.Dial` method sometimes tried to connect to obviously invalid addresses (e.g. with missing port). although a preliminary endpoint check is performed, some errors were ignored, and they still popped up during the subsequent dial. Thus, in general the client's behavior was correct and the expected error was still caught. Thus, in general, the client's behavior was correct and the error was still caught, however, unnecessary obviously failed actions were made, which could be cut off at the pre-check stage. Now the `util.ParseURI` function has been improved and catches most cases. Signed-off-by: Leonard Lyubich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3378685 - Browse repository at this point
Copy the full SHA 3378685View commit details
Commits on Nov 19, 2024
-
client: Unify homogeneous internal call mechanics
There is no any point to have them different. Signed-off-by: Leonard Lyubich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bdfaa0e - Browse repository at this point
Copy the full SHA bdfaa0eView commit details -
client: Return error from unimplemented test methods
Nil response without an error can lead to the undesired behavior. Since other methods are not expected to be called, unimplemented error fits the best. Signed-off-by: Leonard Lyubich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 843085c - Browse repository at this point
Copy the full SHA 843085cView commit details -
client: Drop overriding of session and netmap calls via global vars
There is already an interface for this. Also, changing global variables is always weird. Signed-off-by: Leonard Lyubich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 924a998 - Browse repository at this point
Copy the full SHA 924a998View commit details -
WIP: client: Unify the override of all operations
For two operations it has already been properly done, and for the rest for some reason through global variables. Signed-off-by: Leonard Lyubich <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aaeeee5 - Browse repository at this point
Copy the full SHA aaeeee5View commit details