client: Improve testing and increase coverage #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the added tests fails: it is planned to be corrected in the future. Signed-off-by: Leonard Lyubich <[email protected]>
Previously, `Client.Dial` lost causing error of network endpoint parsing. Although the method returned "invalid endpoint options" error, the original reason could not be obtained. This made debugging difficult. Now causes are kept and returned. For this, function `WithNetworkURIAddress` is inlined and the `ParseURI` error is not ignored. Fixes one of the corresponding tests. Signed-off-by: Leonard Lyubich <[email protected]>
The function is placed inside the lib to facilitate its support and as a preliminary preparation for the obsolescence of `github.com/nspcc-dev/neofs-api-go/v2` module. Signed-off-by: Leonard Lyubich <[email protected]>
The function return zeros on multiaddr input. Signed-off-by: Leonard Lyubich <[email protected]>
Previously, `Client.Dial` method sometimes tried to connect to obviously invalid addresses (e.g. with missing port). although a preliminary endpoint check is performed, some errors were ignored, and they still popped up during the subsequent dial. Thus, in general the client's behavior was correct and the expected error was still caught. Thus, in general, the client's behavior was correct and the error was still caught, however, unnecessary obviously failed actions were made, which could be cut off at the pre-check stage. Now the `util.ParseURI` function has been improved and catches most cases. Signed-off-by: Leonard Lyubich <[email protected]>
There is no any point to have them different. Signed-off-by: Leonard Lyubich <[email protected]>
Nil response without an error can lead to the undesired behavior. Since other methods are not expected to be called, unimplemented error fits the best. Signed-off-by: Leonard Lyubich <[email protected]>
There is already an interface for this. Also, changing global variables is always weird. Signed-off-by: Leonard Lyubich <[email protected]>
For two operations it has already been properly done, and for the rest for some reason through global variables. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
client
branch
from
f2efe1d
to
aaeeee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc.Conndirectly