Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stubs gatk4 #6672

Merged
merged 5 commits into from
Sep 25, 2024
Merged

add stubs gatk4 #6672

merged 5 commits into from
Sep 25, 2024

Conversation

famosab
Copy link
Contributor

@famosab famosab commented Sep 20, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Relates to #4570

nvnieuwk
nvnieuwk approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two formatting comments but nothing breaking 🚀

modules/nf-core/gatk4/collectsvevidence/tests/main.nf.test Outdated Show resolved Hide resolved
modules/nf-core/gatk4/collectsvevidence/tests/main.nf.test Outdated Show resolved Hide resolved
@famosab famosab added this pull request to the merge queue Sep 25, 2024
Merged via the queue into nf-core:master with commit 6b3bf38 Sep 25, 2024
20 checks passed
@famosab famosab deleted the gatk-stub branch September 25, 2024 08:21
herpov pushed a commit to herpov/modules that referenced this pull request Oct 2, 2024
@famosab
add stubs gatk4 (nf-core#6672)
037b2a8 
* add stubs

* run lint --fix

* fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

@sateeshperi sateeshperi sateeshperi approved these changes

@mjcipriano mjcipriano Awaiting requested review from mjcipriano

@hseabolt hseabolt Awaiting requested review from hseabolt

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse is a code owner

@yocra3 yocra3 Awaiting requested review from yocra3

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@famosab @sateeshperi @nvnieuwk