Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Unpin docutils #1127

Merged
merged 1 commit into from
Jul 18, 2024
Merged

docs: Unpin docutils #1127

merged 1 commit into from
Jul 18, 2024

Conversation

joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Jul 17, 2024

Prompted by #1126

Unpinning docutils to be able to pull in the latest sphinx-argparse to fix doc builds.

Release checklist

internal updates only

Prompted by #1126

Unpinning docutils to be able to pull in the latest sphinx-argparse
to fix doc builds.
@joverlee521
Copy link
Contributor Author

From 567247e that pinned docutils ~2 years ago:

docutils 0.18 does not seem to install well with Python 3.10. Pinning to
earlier versions seems to fix the issue.

This is no longer an issue in the docs-ci, which is using the current default Python 3.12.
Does this affect anyone building docs locally?

Copy link
Member

@victorlin victorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just created the docs environment locally with this PR change and a Python 3.10 pin. docutils resolved to version 0.20.1 which works fine. If anyone experiences issues, they should be able to fix by recreating the environment from conda.yaml.

@joverlee521 joverlee521 merged commit b6efca7 into master Jul 18, 2024
13 checks passed
@joverlee521 joverlee521 deleted the fix-docs-build branch July 18, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants