Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: docs build failing #1126

Closed
victorlin opened this issue Jul 17, 2024 · 5 comments
Closed

CI: docs build failing #1126

victorlin opened this issue Jul 17, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@victorlin
Copy link
Member

First noticed in CI run:

▶ Run make html
Running Sphinx v5.3.0

Extension error:
Could not import extension sphinxarg.ext (exception: cannot import name 'get_default_settings' from 'docutils.frontend' (/usr/share/miniconda/envs/test/lib/python3.12/site-packages/docutils/frontend.py))
make: *** [Makefile:20: html] Error 2
Error: Process completed with exit code 2.
@victorlin victorlin added the bug Something isn't working label Jul 17, 2024
@victorlin victorlin mentioned this issue Jul 17, 2024
Merged
@joverlee521
Copy link
Contributor

Ah, same issue as nextstrain/docs.nextstrain.org#214.

I should have realized this would be an issue elsewhere, we should probably pin all uses of sphinx-argparse. GH search shows we need to update ncov, auspice, and nextclade

@joverlee521
Copy link
Contributor

Oh actually, upstream issue seems to be resolved in new release.

@joverlee521
Copy link
Contributor

Ah, fix in sphinx-argparse requires docutils>=0.19 but we pin docutils<0.18.

joverlee521 added a commit that referenced this issue Jul 17, 2024
@joverlee521
docs: Unpin docutils
4dc9674 
Prompted by #1126

Unpinning docutils to be able to pull in the latest sphinx-argparse
to fix doc builds.
@joverlee521 joverlee521 mentioned this issue Jul 17, 2024
Merged
@joverlee521
Copy link
Contributor

Unpinning docutils seems to fix the docs build: #1127

@victorlin
Copy link
Member Author

Fixed by #1127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@victorlin @joverlee521